Add "document-before-save-as" signal #3572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugel-
reviewed
Oct 4, 2023
| * | ||
| * @since TODO | ||
| */ | ||
| signal void (*document_before_save_as)(GObject *obj, GeanyDocument *doc, gpointer user_data); |
There was a problem hiding this comment.
Perhaps add a boolean return value to potentially allow the plugin to block saving the file?
There was a problem hiding this comment.
Hmm, I'm not sure if plugins should be allowed to do that and what exactly would this be good for. Do you have some example?
There was a problem hiding this comment.
No, the plugin should not block a user saving a file, under any circumstances.
techee
force-pushed
the
document_before_save_as
branch
from
bd9e5c0
to
eab9cc1
Compare
|
Looks ok to me but I know nothing about GTK objects, but it looks the same as document_before_save :-) |
Right now only the "document-save" is fired when performing "save as" which lacks the information about the original file name (which, for instance, is necessary for the LSP client where it needs to notify the server that the "old" document was closed and the document under the new name opened).
techee
force-pushed
the
document_before_save_as
branch
from
eab9cc1
to
0dfd465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now only the "document-save" is fired when performing "save as" which lacks the information about the original file name (which, for instance, is necessary for the LSP client where it needs to notify the server that the "old" document was closed and the document under the new name opened).
Right now the plugin at https://github.com/techee/geany-lsp has the code using this signal commented-out - I'll uncomment it once it's added to Geany (so renaming a file might cause problems synchronizing the document with the server with the current implementation).