Release 2.0 documentation #3593

eht16 · 2023-10-11T10:38:08Z

Add NEWS for 2.0, update documentation screenshots and add docs for the "Change history" feature.

Remarks for the NEWS items:

I left out names for Jiří and Thomas as you count as core developers for long I'd say. This doesn't mean your work is less appreciated ❤️
I skipped many smaller or non user visible changes or follow-up PRs to not bloat the list too much
@techee are tere any macOS specific items missing?
if anyone miss his favorite PR or so, shout out
based on the amount of commits and PRs, this is a Jiří+Thomas release :). Thank you!
Should we maybe better highlight the many ctags changes?

Thanks @b4n, @kugel-, @elextr, @techee, @ntrel, @frlan and all the others!

doc/images/build_menu_commands_dialog.png

b4n · 2023-10-11T12:36:16Z

Thanks for updating all this! But… I really think there's a problem with the inline icons in the screenshots, they shouldn't be that big -- and they aren't on my end with Adwaita (which seems to be what you used, which makes sense to use IMO).

ntrel

Thanks for updating the docs - I made a few tweaks.

NEWS

doc/geany.txt

eht16 · 2023-10-11T14:51:30Z

Thanks for updating the docs - I made a few tweaks.

Thank you, applied them all.

techee · 2023-10-11T20:13:28Z

@eht16 Thanks for doing the boring job!

I left out names for Jiří and Thomas as you count as core developers for long I'd say. This doesn't mean your work is less appreciated ❤️

No problem at all :-).

@techee are tere any macOS specific items missing?

There were some fixes but nothing really major worth mentioning I think.

Should we maybe better highlight the many ctags changes?

I don't think it's necessary, the big refactorings weren't user-visible. But maybe if #3049 gets merged, an "improved support of ctags file format" could be mentioned so users know they can use these files and there should be no issues with them.

if anyone miss his favorite PR or so, shout out

I would maybe just rephrase "Improve user experience when creating new projects" to something like "Simplify project creation from existing directories with sources" to make it clearer what it is about.

eht16 · 2023-10-11T21:19:40Z

Should we maybe better highlight the many ctags changes?

I don't think it's necessary, the big refactorings weren't user-visible. But maybe if #3049 gets merged, an "improved support of ctags file format" could be mentioned so users know they can use these files and there should be no issues with them.

Yeah, will happily add it once it is merged 🤞

if anyone miss his favorite PR or so, shout out

I would maybe just rephrase "Improve user experience when creating new projects" to something like "Simplify project creation from existing directories with sources" to make it clearer what it is about.

Done, thanks.

b4n · 2023-10-17T07:46:16Z

Yeah, will happily add it once it is merged 🤞

It just got in 😉

techee · 2023-10-17T08:33:07Z

"improved support of ctags file format" could be mentioned so users know they can use these files and there should be no issues with them.

Maybe also worth mentioning that this is the recommended way of generating tag files.

NEWS

doc/images/pref_dialog_templ.png

doc/images/replace_dialog.png

kugel- · 2023-10-17T20:29:55Z

doc/images/pref_dialog_various.png

Hm, the older screenshot shows some contrast between the list items. We kind of regressed here.

This is also theme-dependent, isn't it? I don't remember we changed anything in the dialog?

We could discuss if we do not want to use that theme for screenshots but given the time left, I would postpone this discussion to 2.1+.

This is also theme-dependent, isn't it?

It is, unless we're explicitly asking for the theme to do something like that (there's an option I don't remember, but you're only supposed to use that if things would be hard to comprehend without, and otherwise let the theme decide).

kugel- · 2023-10-17T20:31:38Z

doc/images/main_window.png

I like the proportions of the older screenshot better (msgwin is huge now)

Me too but this is the great Adwaita we all love so much...

I think Enrico wanted to show all the tabs of the message window but unfortunately these are the Adwaita's infamous "bloated and scaled up" tabs from #3063 so they take a huge amount of space :(.

But I think the message window could be made a tiny bit smaller and the whole window could be taller to compensate for this (if Enrico has a big enough monitor).

So far I tried to keep the width and height of the old screenshot. But I don't mind much.

Agreed it could be bit improved having more room for the editor, event with Adwaita. And having it a bit taller is probably no problem. Something like this (though beware! it's a Git build and you can see it)

[edit] and my shadow is ugly, possibly because it was using most of the vertical space of my VM screen?

Ok, so it's just getting bigger again. I pushed a variant with similar dimensions as @b4n's demo.

@eht16 yeah… is it a problem in the generated file?

No, it just that the user reading the documentation would need a resolution big enough to match the screenshot dimensions or the user needs to scroll. But probably no big deal nowadays.

NEWS

kugel- · 2023-10-17T20:34:12Z

Awesome! Can't find words for how much I appreciative your effort.

doc/geany.txt

elextr · 2023-10-18T01:23:25Z

Given our discussions on themes and screenshots, maybe in the "Geany Workspace" section note that the screenshots are dead tortoise ... erm sorry Adwaita theme ;-P

Perhaps after the first screenshot add "Screenshots in the document are the default GTK Adwaita theme, but Geany will adapt to the desktop GTK theme that is set."

The fact that Geany follows the desktop setting actually isn't documented anywhere else AFAICT.

Otherwise LGTM

eht16 · 2023-10-18T08:22:14Z

Perhaps after the first screenshot add "Screenshots in the document are the default GTK Adwaita theme, but Geany will adapt to the desktop GTK theme that is set."

Done.

doc/geany.txt

eht16 · 2023-10-18T20:06:38Z

You guys like to have me updating screenshots I guess...
The screenshot for the prefs dialog with the changed default for the tab label length is updated for 1000 chars, pixels, apples, Euros 😄.

techee · 2023-10-18T20:09:52Z

You guys like to have me updating screenshots I guess...

Nah, it could have totally stayed the way it was.

The screenshot for the prefs dialog with the changed default for the tab label length is updated for 1000 chars, pixels, apples, Euros 😄.

We are aiming for 1000 screenshot updates in this PR :-).

b4n · 2023-10-18T21:06:47Z

You can add #3611 now ;)

b4n · 2023-10-18T21:08:21Z

@eht16 looks like there has been a rebase mishap, and you grabbed some unrelated things in there 😕

eht16 · 2023-10-18T21:19:24Z

@eht16 looks like there has been a rebase mishap, and you grabbed some unrelated things in there 😕

Oops, thanks for notifying. Should be fixed.
I started a first round of squashing the incremental changes and then came #3611 :).

You can add #3611 now ;)

Done.

eht16 · 2023-10-18T21:22:21Z

@elextr @kugel- @b4n could you have a look on the yet open discussions and either resolve or comment on them? We are slightly running out of time.

NEWS

elextr · 2023-10-18T21:44:05Z

I just did a quick rescan, raised one question, not critical just ignore if stupid :-)

LGTM

kugel- · 2023-10-18T22:04:52Z

LGTM

b4n

New image is missing from the build system. Otherwise I didn't check all PR and issue references, but looks good! 👍

b4n · 2023-10-18T22:37:19Z

doc/images/edit_change_history.png

This is not installed!

diff --git a/doc/Makefile.am b/doc/Makefile.am index ea0e0f697..45dbeecef 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -4,6 +4,7 @@ if INSTALL_HTML_DOCS htmldocimagesdir = $(docdir)/html/images dist_htmldocimages_DATA = \ images/build_menu_commands_dialog.png \ + images/edit_change_history.png \ images/find_dialog.png \ images/find_in_files_dialog.png \ images/main_window.png \ diff --git a/doc/meson.build b/doc/meson.build index a9a2c0257..2fa8cab6d 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -19,6 +19,7 @@ tarball = run_command('test', '-f', 'geany.html', check: false) if tarball.returncode() == 0 or rst2html.found() install_data( 'images/build_menu_commands_dialog.png', + 'images/edit_change_history.png', 'images/find_dialog.png', 'images/find_in_files_dialog.png', 'images/main_window.png',

@eht16 I took the liberty to push to this PR with the fix above.

Thanks and sorry.

eht16 added the documentation label Oct 11, 2023

eht16 added this to the 1.39/2.0 milestone Oct 11, 2023

eht16 mentioned this pull request Oct 11, 2023

Update Scintilla to 5.3.7 and Lexilla to 5.2.7 #3551

Merged

b4n reviewed Oct 11, 2023

View reviewed changes

doc/images/build_menu_commands_dialog.png Outdated Show resolved Hide resolved

ntrel reviewed Oct 11, 2023

View reviewed changes

NEWS Outdated Show resolved Hide resolved

doc/geany.txt Outdated Show resolved Hide resolved

doc/geany.txt Outdated Show resolved Hide resolved

b4n reviewed Oct 17, 2023

View reviewed changes

NEWS Outdated Show resolved Hide resolved

b4n reviewed Oct 17, 2023

View reviewed changes

doc/images/pref_dialog_templ.png Outdated Show resolved Hide resolved

b4n reviewed Oct 17, 2023

View reviewed changes

doc/images/replace_dialog.png Outdated Show resolved Hide resolved

kugel- reviewed Oct 17, 2023

View reviewed changes

NEWS Outdated Show resolved Hide resolved

elextr reviewed Oct 18, 2023

View reviewed changes

doc/geany.txt Show resolved Hide resolved

b4n reviewed Oct 18, 2023

View reviewed changes

doc/geany.txt Outdated Show resolved Hide resolved

b4n mentioned this pull request Oct 18, 2023

Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) #3613

Open

eht16 force-pushed the release_2_0_documentation branch from 8ac7883 to 09e82b5 Compare October 18, 2023 20:57

eht16 force-pushed the release_2_0_documentation branch from 09e82b5 to e350698 Compare October 18, 2023 21:12

elextr reviewed Oct 18, 2023

View reviewed changes

NEWS Outdated Show resolved Hide resolved

eht16 force-pushed the release_2_0_documentation branch from 85febd1 to d2186cc Compare October 18, 2023 21:54

b4n requested changes Oct 18, 2023

View reviewed changes

b4n approved these changes Oct 18, 2023

View reviewed changes

eht16 added 3 commits October 19, 2023 17:16

Add NEWS for Geany 2.0

514adec

Add documentation for new Scintilla feature "Change history"

80fec37

Update documentation screenshots

93070a5

eht16 force-pushed the release_2_0_documentation branch from 37647e3 to 93070a5 Compare October 19, 2023 15:17

eht16 merged commit e9af6b5 into geany:master Oct 19, 2023
4 checks passed

eht16 deleted the release_2_0_documentation branch October 19, 2023 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.0 documentation #3593

Release 2.0 documentation #3593

eht16 commented Oct 11, 2023 •

edited

b4n commented Oct 11, 2023

ntrel left a comment

eht16 commented Oct 11, 2023

techee commented Oct 11, 2023

eht16 commented Oct 11, 2023

b4n commented Oct 17, 2023

techee commented Oct 17, 2023

kugel- Oct 17, 2023

eht16 Oct 17, 2023

b4n Oct 17, 2023

kugel- Oct 17, 2023

eht16 Oct 17, 2023

techee Oct 17, 2023

techee Oct 17, 2023

eht16 Oct 17, 2023

b4n Oct 17, 2023 •

edited

eht16 Oct 18, 2023

b4n Oct 18, 2023

eht16 Oct 18, 2023

kugel- commented Oct 17, 2023

elextr commented Oct 18, 2023

eht16 commented Oct 18, 2023

eht16 commented Oct 18, 2023

techee commented Oct 18, 2023

b4n commented Oct 18, 2023

b4n commented Oct 18, 2023

eht16 commented Oct 18, 2023

eht16 commented Oct 18, 2023

elextr commented Oct 18, 2023

kugel- commented Oct 18, 2023

b4n left a comment

b4n Oct 18, 2023

b4n Oct 18, 2023

eht16 Oct 19, 2023

Release 2.0 documentation #3593

Release 2.0 documentation #3593

Conversation

eht16 commented Oct 11, 2023 • edited

b4n commented Oct 11, 2023

ntrel left a comment

Choose a reason for hiding this comment

eht16 commented Oct 11, 2023

techee commented Oct 11, 2023

eht16 commented Oct 11, 2023

b4n commented Oct 17, 2023

techee commented Oct 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

b4n Oct 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kugel- commented Oct 17, 2023

elextr commented Oct 18, 2023

eht16 commented Oct 18, 2023

eht16 commented Oct 18, 2023

techee commented Oct 18, 2023

b4n commented Oct 18, 2023

b4n commented Oct 18, 2023

eht16 commented Oct 18, 2023

eht16 commented Oct 18, 2023

elextr commented Oct 18, 2023

kugel- commented Oct 18, 2023

b4n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eht16 commented Oct 11, 2023 •

edited

b4n Oct 17, 2023 •

edited