Move "Virtual Spaces" preference to "Editor -> Features" #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Editor -> Display" is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing. Close geany#3605.
|
Looks good - I just tested this PR and it works as described (no way for a human being to review the XML diff itself). In the future we could introduce some tab like "Behavior" which is so generic-sounding we'd be free to place there just anything :-). |
|
Looks good - I just tested this PR and it works as described (no way for a human being to review the XML diff itself).
Use Git's own diff to see it, and enable highlighting of moved lines. Almost all of it is just moved, minus a few lines holding indices and such (and maybe uselessly setting an active radio button, I don't remember if I left it in there and am on a phone)
In the future we could introduce some tab like "Behavior" which is so generic-sounding we'd be free to place there just anything :-).
Hehe, smart 🤓
|
What, "General" isn't general enough ;-P |
eht16
reviewed
Nov 1, 2023
| <property name="receives-default">False</property> | ||
| <property name="tooltip-text" translatable="yes">Do not show virtual spaces</property> | ||
| <property name="use-underline">True</property> | ||
| <property name="active">True</property> |
There was a problem hiding this comment.
This seems new but probably added by Glade automatically and we set an explicit default value in the code anyway, so it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Editor -> Display" is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing.
Close #3605.