Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Add icon with geany program #3812

Merged
merged 1 commit into from Apr 14, 2024
Merged

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Apr 4, 2024

No description provided.

@b4n
Copy link
Member

b4n commented Apr 4, 2024

We lack a Meson Windows job to tell, but at least it doesn't seem to have broken the Linux one (as expected).
I don't know might about this, but it looks believable :)

@eht16
Copy link
Member

eht16 commented Apr 14, 2024

Looks fine and works on Windows, the icon and the other meta information on the executable are set properly.

We lack a Meson Windows job to tell

We could add it. I might work on this at some point (days, weeks, months, who knows 😄 ).

@eht16 eht16 merged commit fc91262 into geany:master Apr 14, 2024
4 checks passed
@eht16
Copy link
Member

eht16 commented Apr 14, 2024

@Biswa96 thanks!

@Biswa96 Biswa96 deleted the meson-add-geany-icon branch April 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants