[Make Custom Target] Always put a space between command and argument #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elextr
requested changes
Apr 8, 2024
There was a problem hiding this comment.
The space is currently only added to pre-0.19 formats, so adding it to all formats is an incompatible change. It assumes that the user is typing a full argument as they are required to do pre-0.19 but post 0.19 formats allow them to only have to type part of the argument.
Currently if the user configured "my_build_script f" in the GUI for custom command and typed "oo" the command is "my_build_script foo" but this change will make it "my_build_script f oo" with no way to recover.
|
At least with #3833 it'll be clearer what command gets run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard coding a space after
makefor the default command, always put a space.Before, if the user changes the command, it's easy for them to remove the trailing space, and the argument then gets tacked on to the command name, changing which program is run.