Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filetype_extensions.conf (Assembly) #722

Closed
wants to merge 2 commits into from
Closed

Update filetype_extensions.conf (Assembly) #722

wants to merge 2 commits into from

Conversation

DevynCJohnson
Copy link
Contributor

Added various Assembly src file-extensions.

Assembly code has a variety of extensions that indicate a particular target system. For instance, ".a51" and ".asm51" contain Assembly code specifically for the 8051 microprocessor.

Added various Assembly src file-extensions.

Assembly code has a variety of extensions that indicate a particular target system. For instance, ".a51" and ".asm51" contain Assembly code specifically for the 8051 microprocessor.
@@ -7,7 +7,7 @@ Abc=*.abc;*.abp;
ActionScript=*.as;
Ada=*.adb;*.ads;
Asciidoc=*.asciidoc;*.adoc;
ASM=*.asm;
ASM=*.asm;*.asm51;*.a51;*.asm;*.ll;*.s03;*.s79;*.s82;*.s90;*.s;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*.asm is duplicated.
I can't find anything using *.ll as an assembly extension. Seems to be use by Lex and some obscure web stuff or something, but nothing about assembly.

*.S might be a nice addition, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I bet that duplicate mistake does not give me a good first-impression on this team. (^u^)

*.ll is LLVM assembly.

From now on, I will be discuss my intended commits and ideas on the Geany-dev mailing list before submitting contributions. Hopefully, that will save Geany's GitHub team some time and inconvenience. I will also include more detailed commit notes and be more detailed in explanations.

@b4n
Copy link
Member

b4n commented Oct 31, 2015

Does all those extensions refer to assembly dialects the ASM filetype actually supports? There is like a gazillion dialects, and they often are completely different, so it needs to actually be compatible.

Added "*.S"
Removed duplicate "*.asm" (my mistake)
"*.asm51" and "*.a51" are 8051 assembly files; Geany seems to highlight such code well
@DevynCJohnson
Copy link
Contributor Author

@b4n , true, there are numerous assembly extensions. Geany does support 8051 assembly, so I added those extensions (asm51 & a51) since I use them sometimes.

@elextr
Copy link
Member

elextr commented Nov 1, 2015

The lexer supports a sort of combined NASM/MASM assembler format (according to the comment) and doesn't care what the target chip is so it should be fairly flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants