Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filetype_extensions.conf (SVG, Diff patches, and more) #737

Closed
wants to merge 1 commit into from
Closed

Update filetype_extensions.conf (SVG, Diff patches, and more) #737

wants to merge 1 commit into from

Conversation

DevynCJohnson
Copy link
Contributor

[ci skip]

- Added "*.dash" to "Sh="
Dash is another shell scripting language like Ash.
The lexer and parser used by Geany for shell scripts works with *.dash. 
- Added "*.svg" to "XML="
SVG (Scalable Vector Graphics) is supported by all major web-browsers
https://en.wikipedia.org/wiki/Scalable_Vector_Graphics
http://www.w3.org/Graphics/SVG/
- Added "*.x3d" to "XML="
X3D has many file-extensions, but "*.x3d" is the most common
X3D: ISO standard XML-based file format for representing 3D computer graphics
https://en.wikipedia.org/wiki/X3D
http://www.web3d.org/x3d/what-x3d
- Added "*.debdiff;*.dpatch;*.kpatch;" to "Diff="
kpatch: live Linux kernel patches
dpatch: directory patch ( http://man.he.net/man7/dpatch )
debdiff: diff file for comparing two *.deb files ( http://manpages.ubuntu.com/manpages/vivid/en/man1/debdiff.1.html )
@DevynCJohnson
Copy link
Contributor Author

This has not been merged yet. Is there a problem with this, is someone very busy, or is their something I could do to make this better?

@DevynCJohnson DevynCJohnson changed the title Update filetype_extensions.conf Update filetype_extensions.conf (SVG, Diff patches, and more) Nov 11, 2015
@eht16
Copy link
Member

eht16 commented Nov 11, 2015

In the past we used to reject adding arbitrary filetype extensions to not spam the default configuration too much. E.g. there were already some requests to add .dpatch and friends, but these are quite specific to Debian. Same goes for other specific extensions. E.g. Debian and ArchLinux patch their specific extensions into their respective distribution packages of Geany which is OK.

Since adding new extensions to the config is documented and very easy for the user, I'd say there is no need to add those extensions to the default configuration.

@elextr
Copy link
Member

elextr commented Nov 12, 2015

And there is a release due this weekend so you can assume everybody is busy.

Finally, you need to be patient, everybody in the Geany camp is a volunteer, you have to let them have time to comment on something.

@DevynCJohnson
Copy link
Contributor Author

Okay, thanks. I will be sure to add arbitrary and "odd" file-type extensions to the wiki. I apologize for any inconvenience.

@b4n
Copy link
Member

b4n commented Nov 12, 2015

I somehow like SVG myself because I find it rather common, the others I really don't know… e.g. I didn't ever see a .dash script, all scripts I know that are supposed to be run by DASH have the common .sh extension rather than a specific one.
X3D I don't know, but if it's an open standard in a trendy area like WebGL it might make sense to support it out of the box -- although not maybe people are likely to open SVG or X3D files in a text editor very often :)

Anyway, in the end I kinda feel like @eht16, we can't realistically add everything that may exist out there in the world, and it'd become a mess if we did anyway. So I guess we prefer only adding "common" (now, what is common? :)) extensions by default.

@DevynCJohnson
Copy link
Contributor Author

@b4n , you do make a good point.

@eht16
Copy link
Member

eht16 commented Nov 12, 2015

Let's add the SVG one and drop the rest? I see that SVG is widely used and just XML.
Regarding dash I agree with @b4n, never see a .dash file, mostly just .sh or .zsh.

@elextr
Copy link
Member

elextr commented Nov 12, 2015

Why do we need to add the SVG extension? The XML magic already detects SVG as XML without it.

@DevynCJohnson DevynCJohnson deleted the patch-5 branch November 15, 2015 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants