Cleanup encodings init() #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not tested, but LGTM at a glance. |
|
|
||
| while (order < group_size) /* the biggest group has 13 elements */ | ||
| /** TODO can it be optimized? ATM 882 runs at line "if (encoding->group ...)" */ |
There was a problem hiding this comment.
Is this comment still relevant, and if so which "if" does it refer to? AFAICT there is no if(encoding->group line in the following loop.
There was a problem hiding this comment.
well, it's still not great so maybe. And yeah, fixed the reference that I changed at some point but changed it back later.
Rewrite a part of `encodings_init()` to remove duplication and some hard-coded values. This gives us the item for UHC back, that was lost when adding CP932 in 9d9f40c, due to a missing update of the hard-coded group elements count.
Simplify and optimize creation of the sorted menus by taking advantage of the fact they might already be partially sorted, and that we can at least add one entry to each group in each run. This goes from 4032 runs to 882, which while definitely not optimal for adding 126 items, is probably totally good enough and don't warrant duplicating the encoding array and sort it. Though, such optimization doesn't matter as it's not what takes time in this function, which is probably rather the widgets creation.
b4n
force-pushed
the
cleanup/encodings_init
branch
from
5bfa995
to
4821770
Compare
|
@codebrainz fair enough, I used shiny C99 for loop declarations all through this function :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.