Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate filetype_id #931

Closed
wants to merge 2 commits into from
Closed

Deprecate filetype_id #931

wants to merge 2 commits into from

Conversation

techee
Copy link
Member

@techee techee commented Mar 4, 2016

Replace filetype_id with GeanyFiletypeID and deprecate the macro.

Used only in static functions so no API change.
@codebrainz
Copy link
Member

I know it's not from this PR, but I wonder why use a macro instead of a typedef for compatibility?

@b4n
Copy link
Member

b4n commented Mar 4, 2016

I know it's not from this PR, but I wonder why use a macro instead of a typedef for compatibility?

I don't see a reason, and if it was a typedef we could mark it with GEANY_DEPRECATED_FOR(GeanyFiletypeID). We probably should change this right now before a release and people starting to throw in #ifdef filetype_id -- no, I doubt anybody would do that, but still.

@b4n b4n mentioned this pull request Mar 4, 2016
@b4n
Copy link
Member

b4n commented Mar 4, 2016

@techee I re-did virtually the same in #932. For some reason this branch has merge conflicts and it was so easy replacing the occurrences (and checking them on the way) I didn't even try using your patch. If you'd like credit, I can fix that.

That other PR replaces the macro with a typedef, too, and marks it deprecated.

@b4n
Copy link
Member

b4n commented Mar 4, 2016

Oh, conflicts arose from the TMParserType change apparently.

@codebrainz
Copy link
Member

I seem to remember there were quite a few places where gint was used for filetype ID, should we fix those now too?

@techee
Copy link
Member Author

techee commented Mar 5, 2016

Deprecated by #932. Closing.

@techee techee closed this Mar 5, 2016
@b4n b4n added this to the 1.27 milestone Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants