Avoid NULL dereference when typing a dot in a file without tags #943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@techee
NULL
check was removed in 292383c, was that really expected?Other solution would be early return in
autocomplete_scope()
whendoc->tm_file
isNULL
, but that would mean that there wouldn't be scope completion in unsaved files.We need a fix ASAP, as it happens whenever typing
.
in an unsaved file, or a file with no tags parser. E.g. you can reproduce by opening a new geanygeany -vi
and typinga.
, boom.