Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagmanager: make doxygen comments and typedefs gtkdoc generation frie… #956

Merged
merged 2 commits into from Mar 9, 2016

Conversation

kugel-
Copy link
Member

@kugel- kugel- commented Mar 9, 2016

…ndly

Because of the missing "typedef struct TMFoo" it was missing from the gtkdoc
header (the struct listings are always without typedef). This is also
consistent with the rest of geany.

@gironly for TMParserType so it's picked up as well.

@b4n

@b4n
Copy link
Member

b4n commented Mar 9, 2016

OK. How comes the Scintilla typedef isn't needed anymore?

@kugel-
Copy link
Member Author

kugel- commented Mar 9, 2016

Oops, this is actually mixed up with #948. including sciwrappers.h makes the manual typedef unecessary.

@kugel- kugel- closed this Mar 9, 2016
@kugel- kugel- reopened this Mar 9, 2016
@b4n
Copy link
Member

b4n commented Mar 9, 2016

Okay, but we then need to merge them in order. Maybe combine those?

gtkcompat.h is more convinient, and includes gtk.h and glib.h. Due to
including ScintillaWidget.h, the manual ScintillaObject typedef isn't required
anymore.
…ndly

Because of the missing "typedef struct TMFoo" it was missing from the gtkdoc
header (the struct listings are always without typedef). This is also
consistent with the rest of geany.

@gironly for TMParserType so it's picked up as well.
@kugel- kugel- force-pushed the tm-gir-fix branch 2 times, most recently from 1561cee to d868130 Compare March 9, 2016 21:50
@b4n b4n merged commit d868130 into geany:master Mar 9, 2016
b4n added a commit that referenced this pull request Mar 9, 2016
Fix and cleanup GtkDoc header generation regarding TagManager's types.
@b4n b4n added this to the 1.27 milestone Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants