Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify-gpg-signature.md #35

Closed
wants to merge 2 commits into from
Closed

Update verify-gpg-signature.md #35

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2021

Added 2 lines at the top to explain users how to get gpg, of particular use for non-Linux users.

Fixes #34

Added 2 lines at the top to explain users how to get `gpg`, of particular use for non-Linux users.
Copy link
Member

@eht16 eht16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.
I have only two minor remarks.

@@ -1,6 +1,10 @@
Verifying GPG signatures of Geany and Geany-Plugins releases
==========

You can use the `gpg` utility. On GNU/Linux distributions, if you don't have it, you can get it with `sudo apt install gpg`. On other OS-es, see https://gnupg.org/download/index.html and https://gnupg.org/download/integrity_check.html.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would mind using "on other operating systems, ...". I think we don't need to abbreviate here so much.

@@ -1,6 +1,10 @@
Verifying GPG signatures of Geany and Geany-Plugins releases
==========

You can use the `gpg` utility. On GNU/Linux distributions, if you don't have it, you can get it with `sudo apt install gpg`. On other OS-es, see https://gnupg.org/download/index.html and https://gnupg.org/download/integrity_check.html.

Here is how to use `gpg` on Linux and related:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this a sub heading, like: ### Here is how to use gpgon Linux and related so it also structures the document a bit more.

Copy link
Author

@ghost ghost Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think both are good ideas, and just applied them.

replaced "OS-es" with "operating systems" and added a subheading for the instructions on Linux
@ghost ghost closed this Oct 10, 2021
@ghost ghost deleted the VictorelPetrovich-Verifying-GPG-signatures branch October 10, 2021 18:34
@ghost ghost restored the VictorelPetrovich-Verifying-GPG-signatures branch October 10, 2021 18:39
@ghost
Copy link
Author

ghost commented Oct 10, 2021

Oops... I wanted to rename the branch, and I didn't know it would automatically close this pull request! I'm goint to make another one, from the renamed branch.

@ghost ghost deleted the VictorelPetrovich-Verifying-GPG-signatures branch October 10, 2021 18:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to verify GPG signatures on Windows
1 participant