New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste error explanation into error reply #1066
Conversation
a1e9b06Pallet tests (values are in nanosegconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
9b71770Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
8350ae8Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
7cc1f25Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
f424f34Pallet tests (values are in nanoseconds)Total execution time
name = pallet-gas
name = pallet-gear
name = pallet-gear-debug
name = pallet-gear-messenger
name = pallet-gear-payment
name = pallet-gear-program
name = pallet-usage
Runtime tests (values are in nanoseconds)Total execution time
name = Async RwLock
name = Async init
name = Async-await
name = Async-duplicates-sync
name = Async-multisig (well known cases)
name = Async-sign (well known cases)
name = Basic capacitor check
name = Decoder
name = Futures-unordered
name = Incomplete-async-payloads
name = Memory test
name = Messages to failed program are handled properly
name = Meta ping (simple check)
name = Multiping
name = Ping-pong
name = Program_id test
name = State-rollback
name = Test create_program sys-call
name = Trap test
name = Wait test
name = basic
name = collector-1
name = guestbook test
name = gui test
|
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
- Coverage 75.22% 74.70% -0.53%
==========================================
Files 95 97 +2
Lines 9045 9175 +130
==========================================
+ Hits 6804 6854 +50
- Misses 2241 2321 +80
Continue to review full report at Codecov.
|
One more related issue opened. It's about extended capabilities of this PR: #1084. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! ⚙️
Resolves #970.
Release notes: Now error replies contain error explanations in the payload, so the programs and user side have more information about the occurred error. When error message sent to user (it propagates event and probably adds to mailbox), it contains string explanation of the error in payload, formed by display formatter. When error message sent to program, it contains encoded bytes of error structure, see more updates on it in #1084.