refactor(node)!: Store only first missing block in scheduler #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark0f
added
A0-pleasereview
breathx
added
A3-gotissues
# Conflicts: # Cargo.lock # gclient/src/api/calls.rs
This reverts commit 2349d77.
ark0f
added
A0-pleasereview
ark0f
changed the title
shamilsan
changed the title
shamilsan
changed the title
breathx
requested changes
Apr 25, 2023
There was a problem hiding this comment.
case:
block N contains no tasks, first missed block = None
block N+1 contains tasks, but block producer missed run_queue extrinsic or runtime upgrade occurs
block N+2 contains tasks and starts execute them because missed blocks = None so tasks from block N+1 lost forever
grishasobol
reviewed
May 3, 2023
# Conflicts: # runtime/gear/src/migrations.rs # runtime/vara/src/migrations.rs
breathx
approved these changes
May 9, 2023
|
@ark0f Are we ready to merge this brilliant PR? |
|
@ark0f merge master, please, and lets merge it |
shamilsan
added
A2-mergeoncegreen
# Conflicts: # runtime/gear/src/migrations.rs # runtime/vara/src/migrations.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1333
A little internal optimization. We stored a set of block numbers whose on-chain tasks were skipped so we can process them later. Now we store only first block and process tasks up to current block (including). It makes internal algorithm a little bit simpler and uses less storage memory.