Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node, core): add pay_program_rent extrinsic/syscall #2535

Merged
merged 39 commits into from
May 18, 2023
Merged

feat(node, core): add pay_program_rent extrinsic/syscall #2535

merged 39 commits into from
May 18, 2023

Conversation

gshep
Copy link
Member

@gshep gshep commented Apr 12, 2023 •
edited

Resolves #2509

  • extrinsic
  • syscall
  • test case that syscall works
  • corresponding weights

@gear-tech/dev

@gshep gshep added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D1-core Gear Core D2-node Gear Node C1-feature Feature request labels Apr 12, 2023
@gshep gshep self-assigned this Apr 12, 2023
@gshep gshep force-pushed the gshep/issue-2509 branch 4 times, most recently from 434ed7d to 9aab78f Compare April 21, 2023 11:24
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Apr 24, 2023
Base automatically changed from gshep/issue-2301-1 to master April 26, 2023 10:55
@gshep gshep marked this pull request as ready for review May 1, 2023 11:47
gshep
gshep commented May 15, 2023
View reviewed changes
pallets/gear/src/internal.rs Outdated Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented May 15, 2023

add different benches for extrinsic

@gshep
Copy link
Member Author

gshep commented May 15, 2023

216

discussed to set to 125_000_000

ark0f
ark0f reviewed May 15, 2023
View reviewed changes
Copy link
Member

@ark0f ark0f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting for additional changes from conversations

core-processor/src/common.rs Outdated Show resolved Hide resolved
core-processor/src/ext.rs Outdated Show resolved Hide resolved
@gshep gshep requested review from breathx and ark0f May 16, 2023 10:27
@gshep gshep changed the title feat(node, core): add pay_rent extrinsic/syscall feat(node, core): add pay_program_rent extrinsic/syscall May 16, 2023
ark0f
ark0f approved these changes May 16, 2023
View reviewed changes
gsys/src/lib.rs Outdated Show resolved Hide resolved
runtime/gear/src/constants.rs Outdated Show resolved Hide resolved
breathx
breathx requested changes May 17, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish line!

examples/binaries/sys-calls/src/lib.rs Outdated Show resolved Hide resolved
gstd/src/exec.rs Outdated Show resolved Hide resolved
gsys/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/internal.rs Outdated Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
@gshep gshep requested a review from breathx May 17, 2023 20:32
breathx
breathx approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
pallets/gear/src/tests.rs Show resolved Hide resolved
@gshep gshep added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 18, 2023
@gshep gshep merged commit 7d54bc2 into master May 18, 2023
8 checks passed
@gshep gshep deleted the gshep/issue-2509 branch May 18, 2023 13:07
@osipov-mit osipov-mit mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisInSky DennisInSky DennisInSky left review comments

@NikVolf NikVolf NikVolf approved these changes

@ark0f ark0f ark0f approved these changes

@breathx breathx breathx approved these changes

Assignees

@gshep gshep

Labels
A2-mergeoncegreen PR is ready to merge after CI passes B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request D1-core Gear Core D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to pay rent for programs
6 participants
@gshep @NikVolf @breathx @DennisInSky @ark0f @shamilsan