Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Auto replies #2547

Merged
merged 40 commits into from
May 23, 2023
Merged

feat!: Auto replies #2547

merged 40 commits into from
May 23, 2023

Conversation

breathx
Copy link
Member

@breathx breathx commented Apr 16, 2023

Resolves #1676, resolves #1741 and resolves #1742.

@breathx breathx marked this pull request as ready for review April 17, 2023 15:20
@breathx breathx added A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request labels Apr 17, 2023
@shamilsan shamilsan changed the title Auto replies feat!: Auto replies Apr 25, 2023
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/tests.rs Outdated Show resolved Hide resolved
pallets/gear/src/tests.rs Outdated Show resolved Hide resolved
@breathx breathx mentioned this pull request May 22, 2023
11 tasks
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 22, 2023
@breathx breathx merged commit 9df4b02 into master May 23, 2023
8 checks passed
@breathx breathx deleted the dn-auto-replies branch May 23, 2023 13:59
@ark0f ark0f restored the dn-auto-replies branch May 24, 2023 16:13
@@ -62,6 +62,7 @@ impl CliConfiguration for RuntimeTestCmd {
}

#[cfg(any(feature = "gear-native", feature = "vara-native"))]
#[track_caller]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applicable only to functions

argument.extend(block_number);
argument.extend_from_slice(user_id);
argument.extend(local_nonce);
const SALT: &[u8] = b"external";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave previous salt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need migration for that IDs

@ark0f ark0f deleted the dn-auto-replies branch May 30, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request
Projects
None yet
3 participants