-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Auto replies #2547
feat!: Auto replies #2547
Conversation
These demos used to have compatibility problems in runtime spec testing and gear-test spec testing. Furthermore, they don't demonstrate any unique apis and are one of the most older showing demos, so their actuality and useless equals zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💯
@@ -62,6 +62,7 @@ impl CliConfiguration for RuntimeTestCmd { | |||
} | |||
|
|||
#[cfg(any(feature = "gear-native", feature = "vara-native"))] | |||
#[track_caller] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applicable only to functions
argument.extend(block_number); | ||
argument.extend_from_slice(user_id); | ||
argument.extend(local_nonce); | ||
const SALT: &[u8] = b"external"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave previous salt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need migration for that IDs
Resolves #1676, resolves #1741 and resolves #1742.