Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pallet-gear): add weights for sign-ext instructions #2563

Merged
merged 15 commits into from
Jun 6, 2023
Merged

feat(pallet-gear): add weights for sign-ext instructions #2563

merged 15 commits into from
Jun 6, 2023

Conversation

clearloop
Copy link
Member

@clearloop clearloop commented Apr 18, 2023 •
edited

Resolves #2523

  • instr_i32extend8s
  • instr_i32extend16s
  • instr_i64extend16s
  • instr_i64extend32s

@gear-tech/dev

clearloop
clearloop commented Apr 19, 2023
View reviewed changes
pallets/gear/src/benchmarking/mod.rs Show resolved Hide resolved
pallets/gear/src/weights.rs Outdated Show resolved Hide resolved
@clearloop clearloop marked this pull request as ready for review April 19, 2023 13:57
@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Apr 19, 2023
@shamilsan
Copy link
Contributor

@clearloop Stale PR?

@clearloop
Copy link
Member Author

@clearloop Stale PR?

waiting for review =,=

breathx
breathx approved these changes May 15, 2023
View reviewed changes
runtime/vara/src/weights/pallet_gear.rs Outdated Show resolved Hide resolved
@shamilsan shamilsan added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 15, 2023
@clearloop
Copy link
Member Author

clearloop commented May 18, 2023 •
edited

have we missed updating the weights in pallet-gear/src/weights in the script? https://github.com/gear-tech/gear/actions/runs/5017675185/jobs/8996094362#step:15:1001

@StackOverflowExcept1on
Copy link
Member

Yes, I forgot to update this file. Next time we need some kind of unpacking script. It's just cp and sed: https://github.com/gear-tech/gear/blob/master/.github/workflows/benchmarks.yml#L62

@StackOverflowExcept1on
Copy link
Member

Now all tests pass. Can anyone check that the values are ok?

clearloop
clearloop commented May 18, 2023
View reviewed changes
runtime/gear/src/tests.rs Outdated Show resolved Hide resolved
@StackOverflowExcept1on StackOverflowExcept1on mentioned this pull request May 19, 2023
Merged
grishasobol
grishasobol reviewed May 27, 2023
View reviewed changes
pallets/gear/src/schedule.rs Outdated Show resolved Hide resolved
runtime/gear/src/tests.rs Outdated Show resolved Hide resolved
runtime/gear/src/weights/pallet_utility.rs Outdated Show resolved Hide resolved
@breathx breathx requested a review from grishasobol June 1, 2023 20:18
@breathx breathx added A0-pleasereview PR is ready to be reviewed by the team and removed A2-mergeoncegreen PR is ready to merge after CI passes labels Jun 1, 2023
@breathx breathx merged commit 34b4403 into master Jun 6, 2023
8 checks passed
@breathx breathx deleted the cl/issue-2523 branch June 6, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ukint-vs ukint-vs ukint-vs left review comments

@StackOverflowExcept1on StackOverflowExcept1on StackOverflowExcept1on left review comments

@grishasobol grishasobol Awaiting requested review from grishasobol

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct weights for sign extension instructions
6 participants
@clearloop @shamilsan @StackOverflowExcept1on @grishasobol @breathx @ukint-vs