Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(wasm-builder)!: Pass program build features to wasm-builder #2599

Merged
merged 9 commits into from
May 5, 2023
Merged

build(wasm-builder)!: Pass program build features to wasm-builder #2599

merged 9 commits into from
May 5, 2023

Conversation

DennisInSky
Copy link
Member

@DennisInSky DennisInSky commented Apr 27, 2023 •
edited

Resolves #2407 .

It might be a breaking change for some users.

@reviewer-or-team

@DennisInSky DennisInSky added the A0-pleasereview PR is ready to be reviewed by the team label Apr 27, 2023
@DennisInSky DennisInSky self-assigned this Apr 27, 2023
clearloop
clearloop reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@clearloop clearloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but for the testing part, I think we can test it with https://github.com/gear-tech/gear/tree/master/utils/wasm-builder/test-program

utils/wasm-builder/src/wasm_project.rs Outdated Show resolved Hide resolved
utils/wasm-builder/src/wasm_project.rs Outdated Show resolved Hide resolved
utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved
@DennisInSky DennisInSky changed the title build(wasm-builder): Pass program build features to wasm-builder build(wasm-builder)!: Pass program build features to wasm-builder Apr 27, 2023
shamilsan
shamilsan approved these changes Apr 28, 2023
View reviewed changes
utils/wasm-builder/src/cargo_command.rs Show resolved Hide resolved
utils/wasm-builder/src/lib.rs Show resolved Hide resolved
utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved
utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved
@DennisInSky
Copy link
Member Author

lgtm! but for the testing part, I think we can test it with https://github.com/gear-tech/gear/tree/master/utils/wasm-builder/test-program

@clearloop can you please elaborate on it?

@clearloop
Copy link
Member

lgtm! but for the testing part, I think we can test it with https://github.com/gear-tech/gear/tree/master/utils/wasm-builder/test-program

@clearloop can you please elaborate on it?

yep sure

@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Apr 29, 2023
@clearloop clearloop mentioned this pull request May 4, 2023
Closed
1 task
@DennisInSky DennisInSky merged commit 1564100 into master May 5, 2023
8 checks passed
@DennisInSky DennisInSky deleted the dd/wasm-builder-features branch May 5, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

@clearloop clearloop clearloop approved these changes

@techraed techraed Awaiting requested review from techraed

@breathx breathx Awaiting requested review from breathx

Assignees

@DennisInSky DennisInSky

Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support features of programs in wasm-builder
4 participants
@DennisInSky @clearloop @techraed @shamilsan