chore(spec-test): Obsolete some spec-tests and examples [2] #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`demo-block-info` used only to share the result of syscall, furthermore this demo was never been testing with `runtime-spec-tests` due to problems with block numbers compatibility.
`demo-meta` already is totally unused approach and the tests for it don't demonstrate actual supported api. For anything related to metadata and state queries see `demo-new-meta`.
`demo-test-gui` used to be testing instrument for JS side, but it's no longer so. The demo is totally unused. Furthermore, as api-demonstration view-point it uses deprecated api `gstd::metadata!`.
ukint-vs
approved these changes
May 17, 2023
grishasobol
previously requested changes
May 17, 2023
grishasobol
reviewed
May 17, 2023
The yaml doesnt demonstrate any useful apis. Furthermore, this logic already tested with `pallet-gear` in `test_message_processing_for_non_existing_destination` test.
Demo doesnt demonstrate any new apis that `examples/binaries/program-factory` does. Furthermore, in terms of tests the same functionality covered with `pallet-gear`'s `test_create_program_works`, `test_create_program_duplicate` tests.
breathx
force-pushed
the
dn-obsolete-examples-part2
branch
from
57c99de
to
8a8c122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.