Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-gear): Fix infinite loop in calculate_gas rpc #2662

Merged
merged 8 commits into from
May 30, 2023

Conversation

DennisInSky
Copy link
Member

@DennisInSky DennisInSky commented May 17, 2023

Resolves #2663.

@reviewer-or-team

@DennisInSky DennisInSky self-assigned this May 17, 2023
@DennisInSky DennisInSky added the A0-pleasereview PR is ready to be reviewed by the team label May 17, 2023
@DennisInSky DennisInSky changed the title Fix infinite loop in calculate_gas rpc fix(pallet-gear): Fix infinite loop in calculate_gas rpc May 17, 2023
@DennisInSky DennisInSky marked this pull request as ready for review May 17, 2023 12:55
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution

Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues discussed on personal call

@DennisInSky DennisInSky requested a review from breathx May 22, 2023 13:22
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shamilsan
Copy link
Contributor

@DennisInSky Let's resolve conflicts and merge it.

@shamilsan shamilsan added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels May 29, 2023
@DennisInSky DennisInSky merged commit 8ce701b into master May 30, 2023
8 checks passed
@DennisInSky DennisInSky deleted the dd/fix-calc-gas-rpc-inf-loop branch May 30, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'calculate_gas_info' runs infinitely when block remaining gas allowance is less than required gas
4 participants