ci(build-win-native): use symbolic link for pinning toolchain #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilsan
approved these changes
May 22, 2023
StackOverflowExcept1on
added
the
A2-mergeoncegreen
|
I just launched workflow in separate branch: https://github.com/gear-tech/gear/actions/runs/5045063083 |
|
why mv doesn't work? |
Something wrong: https://github.com/gear-tech/gear/actions/runs/5045063083/jobs/9050760353 |
|
@breathx I added an explanation in the PR why the symlink fixes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2665
Previously, this problem may not have been noticed due to the lack of pinning of the toolchain.
The reason we use a symbolic link instead of a move is because the
gear.shscript runscargo buildand for some reasoncargodecided to reinstall the toolchain withoutwasm32-unknown-unknowntarget.The problem appears here:
https://github.com/gear-tech/gear/actions/runs/4729497517/jobs/8963897937#step:15:17