Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): revert self mutability for Ext trait #2677

Merged
merged 1 commit into from
May 23, 2023
Merged

refactor(core): revert self mutability for Ext trait #2677

merged 1 commit into from
May 23, 2023

Conversation

tltsutltsu
Copy link
Contributor

Resolves #904

@gear-tech/dev

@tltsutltsu tltsutltsu added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label May 22, 2023
@tltsutltsu tltsutltsu self-assigned this May 22, 2023
@tltsutltsu tltsutltsu requested a review from breathx May 22, 2023 15:11
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels May 22, 2023
@tltsutltsu tltsutltsu merged commit 78dfa07 into master May 23, 2023
8 checks passed
@tltsutltsu tltsutltsu deleted the tltsutltsu/ext-trait-revert-mutability branch May 23, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

@breathx breathx Awaiting requested review from breathx

Assignees

@tltsutltsu tltsutltsu

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert self mutability for Environment trait
2 participants
@tltsutltsu @shamilsan