Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-fuzzer): Make gas limit variable in runtime-fuzzer #2678

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

mertwole
Copy link
Member

Resolves #2328

@mertwole mertwole changed the title Make gas limit variable in runtime-fuzzer refactor(runtime-fuzzer): Make gas limit variable in runtime-fuzzer May 22, 2023
@shamilsan shamilsan added the A0-pleasereview PR is ready to be reviewed by the team label May 28, 2023
@techraed
Copy link
Member

Actually Im thinking of closing this, becase what can be tested with a low gas value, is actually tested with a max gas value and too expensive program. This case is something common while fuzzer works, as I see from logs. What do you think?

@mertwole @breathx @grishasobol

@techraed
Copy link
Member

techraed commented Jun 1, 2023

due to core-audit/issue-22 error I think different gas limit values is great for testing.

Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such range will mostly run into small gas amount. I'd make it random, but with much more changes close to default gas limit.
and 100% left border should be > 0

@techraed
Copy link
Member

techraed commented Jun 1, 2023

Makes sense

@mertwole mertwole force-pushed the md-fuzzer-variable-gas-limit branch from caf2bda to ab04d5d Compare June 5, 2023 08:32
@breathx breathx merged commit 1d7a9b2 into master Jun 6, 2023
8 checks passed
@breathx breathx deleted the md-fuzzer-variable-gas-limit branch June 6, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gas limit in the fuzzer a randomly generated value
4 participants