Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(weights): Fix SessionValidatorSetMigration weight #2712

Merged
merged 4 commits into from
Jun 3, 2023
Merged

fix(weights): Fix SessionValidatorSetMigration weight #2712

merged 4 commits into from
Jun 3, 2023

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Jun 1, 2023

Resolves #2696

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node D6-gas Change gas charging logic or weights labels Jun 1, 2023
@ark0f ark0f requested review from breathx and ukint-vs June 1, 2023 19:40
@ark0f ark0f changed the title Update SessionValidatorSetMigration refactor(gear,vara): SessionValidatorSetMigration Jun 1, 2023
@ark0f ark0f changed the title refactor(gear,vara): SessionValidatorSetMigration fix(weights): Fix SessionValidatorSetMigration weight Jun 1, 2023
@ark0f
Copy link
Member Author

ark0f commented Jun 1, 2023

Now weight is just 38.75%

ukint-vs
ukint-vs approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@ukint-vs ukint-vs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

runtime/common/src/migration.rs Show resolved Hide resolved
@ark0f ark0f merged commit fc520c6 into master Jun 3, 2023
8 checks passed
@ark0f ark0f deleted the al-session-migration-weight branch June 3, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukint-vs ukint-vs ukint-vs approved these changes

@breathx breathx Awaiting requested review from breathx

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node D6-gas Change gas charging logic or weights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations exceed block weight
2 participants
@ark0f @ukint-vs