Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(node): Benchmark tasks and reduce GasAllowance accordingly #2797

Merged
merged 40 commits into from
Sep 17, 2023
Merged

refactor(node): Benchmark tasks and reduce GasAllowance accordingly #2797

merged 40 commits into from
Sep 17, 2023

Conversation

gshep
Copy link
Member

@gshep gshep commented Jun 16, 2023 •
edited

Resolves #2788

  • get_maximum_task_gas function to get tentative gas amount that will be burned by a task
  • benchmarks for all tasks
  • adjustments

@gear-tech/dev

@gshep
update TaskHandler
af794cb 
return gas amount from all traits methods and from process_with method
@gshep
func get_maximum_task_gas
fc63588 
implement benchmark for RemoveResumeSession
use bechmarked weight for the task
@gshep
tasks_remove_gas_reservation benchmark
718b174
@gshep gshep added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D2-node Gear Node C2-refactoring Refactoring proposal labels Jun 16, 2023
@gshep gshep self-assigned this Jun 16, 2023
@gshep gshep changed the title Draft: refactor(node): Benchmark tasks and reduce GasAllowance accrodingly Draft: refactor(node): Benchmark tasks and reduce GasAllowance accordingly Jun 17, 2023
@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 26, 2023
@gshep gshep changed the title Draft: refactor(node): Benchmark tasks and reduce GasAllowance accordingly refactor(node): Benchmark tasks and reduce GasAllowance accordingly Jun 26, 2023
@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team and removed A0-pleasereview PR is ready to be reviewed by the team labels Jun 26, 2023
grishasobol
grishasobol requested changes Jun 30, 2023
View reviewed changes
pallets/gear/src/weights.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Jul 2, 2023 •
edited

to be reviewed from my side soon

@gshep
Merge remote-tracking branch 'origin/master'
1f9ba49 
Conflicts:
	Cargo.toml
	examples/binaries/waiter/src/code.rs
	examples/binaries/waiter/src/lib.rs
@gshep
make fmt
14196ec
@gshep
set features for constructor dependency
2cd29d3
ark0f
ark0f requested changes Aug 1, 2023
View reviewed changes
examples/binaries/waiter/src/lib.rs Outdated Show resolved Hide resolved
common/src/scheduler/task.rs Outdated Show resolved Hide resolved
common/src/scheduler/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Show resolved Hide resolved
pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
@gshep
Merge remote-tracking branch 'origin/master'
64e5587 
Conflicts:
	Cargo.toml
	examples/binaries/waiter/src/code.rs
	examples/init-wait/Cargo.toml
	examples/waiter/Cargo.toml
	examples/waiter/src/lib.rs
	pallets/gear/src/benchmarking/mod.rs
	pallets/gear/src/mock.rs
	pallets/gear/src/tests.rs
gshep
gshep commented Sep 6, 2023
View reviewed changes
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
@gshep
Merge remote-tracking branch 'origin/master'
4c36795 
Conflicts:
	examples/init-wait/src/code.rs
	gclient/Cargo.toml
	pallets/gear/Cargo.toml
	pallets/gear/src/benchmarking/mod.rs
	pallets/gear/src/manager/task.rs
@gshep
use drain iterator
8867de2
@gshep
fix review remarks
ba40b8b
grishasobol
grishasobol approved these changes Sep 8, 2023
View reviewed changes
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
breathx
breathx approved these changes Sep 10, 2023
View reviewed changes
pallets/gear/src/manager/task.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Show resolved Hide resolved
pallets/gear/src/lib.rs Show resolved Hide resolved
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
pallets/gear/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
ark0f
ark0f approved these changes Sep 12, 2023
View reviewed changes
pallets/gear/src/manager/task.rs Show resolved Hide resolved
@gshep gshep merged commit 50a4ec1 into master Sep 17, 2023
8 checks passed
@gshep gshep deleted the gshep/issue-2788 branch September 17, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@ark0f ark0f ark0f approved these changes

@breathx breathx breathx approved these changes

Assignees

@gshep gshep

Labels
A0-pleasereview PR is ready to be reviewed by the team C2-refactoring Refactoring proposal D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tasks should be benchmarked
4 participants
@gshep @breathx @grishasobol @ark0f