feat(gstd): Introduce max ownership time for Mutex #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisInSky
commented
Jul 7, 2023
breathx
requested changes
Aug 6, 2023
breathx
added
A3-gotissues
DennisInSky
added
A0-pleasereview
|
Re-review @breathx ? |
breathx
approved these changes
Aug 28, 2023
shamilsan
reviewed
Aug 28, 2023
clearloop
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
I'm considering about providing a handbook for program developers since we are introducing more and more features now, the Learn Gear "std" library redirects to https://docs.gear.rs/gstd/ (plus https://wiki.gear-tech.io/docs/getting-started-in-5-minutes/) are obvious not friendly enough for new developers
|
@clearloop please re-review |
shamilsan
pushed a commit
that referenced
this pull request
Sep 11, 2023
shamilsan
added
the
B1-releasenotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea of supporting max ownership time for Mutex (the same will be implemented for RwLock if everyone happy with this approach). Basically, before acquiring the mutex ownership, one can declare in the code max number of blocks they are going to own the mutex for. If there happens another attempt to grab the same mutex after the specified number of blocks, but the mutex has not been released by the first owner yet, the first message execution will get terminated via panic indicating the message exceeded lock ownership time.
@reviewer-or-team