feat(tests, cli): Add subcommand to gear-replay-cli tool
#3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekovalev
added
A0-pleasereview
ekovalev
force-pushed
the
ek-extend-gear-replay-cli
branch
from
92e42da
to
bae6899
Compare
ekovalev
force-pushed
the
ek-extend-gear-replay-cli
branch
from
fa81b3e
to
85e6b8d
Compare
shamilsan
reviewed
Aug 6, 2023
ekovalev
force-pushed
the
ek-extend-gear-replay-cli
branch
from
85e6b8d
to
5380019
Compare
breathx
approved these changes
Aug 7, 2023
ekovalev
added
A3-gotissues
ekovalev
force-pushed
the
ek-extend-gear-replay-cli
branch
from
d9cc225
to
a0e973a
Compare
NikVolf
added
A2-mergeoncegreen
|
@ekovalev rebase to master and rerun CI please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing CLI replays blocks that have already been finalized. However, if an extrinsic panicked at the time of block creation, it would have been dropped and not included in a block, thereby destroying the whole purpose of attempting to get some meaningful information about the root cause of the panic.
To circumvent that, a subcommand is being introduced that would mimic the steps of a block producer (not validator): initialize a block and apply extrinsic through calling the
BlockBuilder_apply_extrinsicruntime api. Current implementation only supports theGear::run()extrinsic, mainly because it is where the message queue is processed, but also because it doesn't have any arguments, therefore the known encoded version of it can be supplied to the runtime api call (without a need of creating anUncheckedExtrinsicby hand and then encoding it - that would require having theRuntimeas an explicit dependency, which we want to avoid).