Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gtest): Add payload to Program::read_state* #3254

Merged
merged 11 commits into from
Sep 19, 2023
Merged

feat(gtest): Add payload to Program::read_state* #3254

merged 11 commits into from
Sep 19, 2023

Conversation

mqxf
Copy link
Contributor

@mqxf mqxf commented Sep 12, 2023

Resolves #3217

@reviewer-or-team

@shamilsan shamilsan added the A0-pleasereview PR is ready to be reviewed by the team label Sep 13, 2023
shamilsan
shamilsan reviewed Sep 13, 2023
View reviewed changes
gtest/src/program.rs Outdated Show resolved Hide resolved
gtest/src/program.rs Outdated Show resolved Hide resolved
breathx
breathx requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree with @shamilsan

shamilsan
shamilsan approved these changes Sep 13, 2023
View reviewed changes
examples/autoreply/src/lib.rs Show resolved Hide resolved
techraed
techraed approved these changes Sep 14, 2023
View reviewed changes
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/program.rs Outdated Show resolved Hide resolved
mqxf and others added 2 commits September 14, 2023 14:56
@mqxf @techraed
Update gtest/src/program.rs
1ca2d21 
Co-authored-by: Sabaun Taraki <taraki.sabaun.rl@gmail.com>
@mqxf
Move payload parameter
ca0b2de
breathx
breathx approved these changes Sep 18, 2023
View reviewed changes
examples/autoreply/src/lib.rs Show resolved Hide resolved
examples/new-meta/tests/read_state.rs Outdated Show resolved Hide resolved
@mqxf mqxf merged commit ee5ce18 into master Sep 19, 2023
8 checks passed
@mqxf mqxf deleted the ms/issue-3217 branch September 19, 2023 11:13
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@techraed techraed techraed approved these changes

@shamilsan shamilsan shamilsan approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtest: Add payload to Program::read_state*
4 participants
@mqxf @techraed @shamilsan @breathx