Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(benchmarks): add proper benchmarks for signal syscalls #3258

Merged
merged 14 commits into from
Sep 26, 2023
Merged

feat(benchmarks): add proper benchmarks for signal syscalls #3258

merged 14 commits into from
Sep 26, 2023

Conversation

tltsutltsu
Copy link
Contributor

@tltsutltsu tltsutltsu commented Sep 12, 2023 •
edited

Resolves: #2825

  • Refactor gr_signal_from and gr_signal_code benchmarks
  • Update weights

@gear-tech/dev

@tltsutltsu tltsutltsu added the D6-gas Change gas charging logic or weights label Sep 12, 2023
@tltsutltsu tltsutltsu self-assigned this Sep 12, 2023
@tltsutltsu tltsutltsu added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Sep 12, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Sep 13, 2023
breathx
breathx requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing is about weight

pallets/gear/src/weights.rs Outdated Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Sep 20, 2023
@tltsutltsu tltsutltsu added A0-pleasereview PR is ready to be reviewed by the team A3-gotissues PR occurred to have issues after the review D6-gas Change gas charging logic or weights and removed A3-gotissues PR occurred to have issues after the review D6-gas Change gas charging logic or weights labels Sep 21, 2023
@tltsutltsu tltsutltsu merged commit a033a22 into master Sep 26, 2023
11 checks passed
@tltsutltsu tltsutltsu deleted the tltsutltsu/benches-for-signal-syscalls branch September 26, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@breathx breathx breathx approved these changes

Assignees

@tltsutltsu tltsutltsu

Labels
A0-pleasereview PR is ready to be reviewed by the team D6-gas Change gas charging logic or weights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proper benchmarks for signal syscalls
3 participants
@tltsutltsu @grishasobol @breathx