Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gstd): Mutex lock monitor #3341

Merged
merged 20 commits into from
Sep 26, 2023
Merged

feat(gstd): Mutex lock monitor #3341

merged 20 commits into from
Sep 26, 2023

Conversation

DennisInSky
Copy link
Member

@DennisInSky DennisInSky commented Sep 22, 2023 •
edited

This PR implements functionality with regards to mutex locks when one lock is still in bound of its duration, i.e. it can't be ousted, whereas another lock comes, but when the first lock excceeds its time limit it has to be ousted, and the second one should get into possesion

@DennisInSky DennisInSky self-assigned this Sep 22, 2023
@DennisInSky DennisInSky changed the title Dd/mx lock monitor feat(gstd): Mutex lock monitor Sep 22, 2023
@DennisInSky DennisInSky marked this pull request as ready for review September 22, 2023 20:59
@DennisInSky DennisInSky added the A0-pleasereview PR is ready to be reviewed by the team label Sep 22, 2023
breathx
breathx requested changes Sep 24, 2023
View reviewed changes
gstd/src/sync/mutex.rs Outdated Show resolved Hide resolved
gstd/src/sync/mutex.rs Outdated Show resolved Hide resolved
gstd/src/async_runtime/locks.rs Show resolved Hide resolved
@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Sep 24, 2023
@DennisInSky DennisInSky added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Sep 25, 2023
breathx
breathx approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to be pushed personally discussed changes of making 0 mutex id valid and using just wrapping logic

@NikVolf NikVolf merged commit 758754a into master Sep 26, 2023
10 checks passed
@NikVolf NikVolf deleted the dd/mx-lock-monitor branch September 26, 2023 06:07
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@breathx breathx breathx approved these changes

@shamilsan shamilsan Awaiting requested review from shamilsan

@grishasobol grishasobol Awaiting requested review from grishasobol

Assignees

@DennisInSky DennisInSky

Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DennisInSky @NikVolf @breathx @shamilsan