Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vara): Maintain total supply consistency in offchain election provider #3389

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

ekovalev
Copy link
Member

@ekovalev ekovalev commented Oct 4, 2023

Provides RewardHandler and SlashHandler associated types in the election-provider-multi-phase pallet Config trait so that the newly minted rewards are offset against the rewards pool and the slashes go to the Treasury instead of being burned.
This will allow to keep the token total supply stable for as long as the rewards offset pool is not empty.

@ekovalev ekovalev added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node C1-feature Feature request labels Oct 4, 2023
pallets/staking-rewards/src/lib.rs Outdated Show resolved Hide resolved
pallets/staking-rewards/src/mock.rs Show resolved Hide resolved
pallets/staking-rewards/src/mock.rs Outdated Show resolved Hide resolved
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ekovalev ekovalev merged commit 71168c5 into master Oct 5, 2023
10 checks passed
@ekovalev ekovalev deleted the ek-better-rewards-handling branch October 5, 2023 11:11
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants