Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): Adding dust and slash handlers #3405

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

ekovalev
Copy link
Member

@ekovalev ekovalev commented Oct 12, 2023

  • Dust and slashes handlers to pallets configs to keep the total issuance consistent
  • Tests

@ekovalev ekovalev added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node C1-feature Feature request labels Oct 12, 2023
@ekovalev ekovalev changed the title feat(node): Adding dust and slash handlers feat(runtime): Adding dust and slash handlers Oct 12, 2023
runtime/vara/src/integration_tests.rs Show resolved Hide resolved
runtime/vara/src/lib.rs Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Oct 15, 2023

Seems all holes for leak of total issuance solved so we are able to introduce migrations with burning token from offset pool to stabilise issuance?

@NikVolf
Copy link
Member

NikVolf commented Oct 16, 2023

Seems all holes for leak of total issuance solved so we are able to introduce migrations with burning token from offset pool to stabilise issuance?

this is better be done via referendum

@ekovalev
Copy link
Member Author

Seems all holes for leak of total issuance solved so we are able to introduce migrations with burning token from offset pool to stabilise issuance?

Seems so. The slash handlers called by other pallets (like bounty and child-bounty) implicitly call the same Treasury::OnSlash(). In all other places we are already handling the imbalances.

@ekovalev ekovalev merged commit bd292dc into master Oct 16, 2023
10 checks passed
@ekovalev ekovalev deleted the ek-maintain-total-supply branch October 16, 2023 13:59
@shamilsan shamilsan added the B1-releasenotes The feature deserves to be added to the Release Notes label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes C1-feature Feature request D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants