feat!(gear-core): check data section for uploading codes #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grishasobol
added
the
A1-inprogress
grishasobol
force-pushed
the
gsobol-check-data-section
branch
from
f75e337
to
6f364ba
Compare
grishasobol
force-pushed
the
gsobol-check-data-section
branch
from
2512d23
to
7d7996c
Compare
grishasobol
requested review from
StackOverflowExcept1on,
breathx and
gshep
and removed request for
StackOverflowExcept1on and
breathx
grishasobol
added
A0-pleasereview
StackOverflowExcept1on
approved these changes
Feb 15, 2024
ukint-vs
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checking that data section lies inside static memory (or inside wasm min memory pages).
After runtime upgrade codes with incorrect data sections cannot be re-instrumented or uploaded.
Insignificant:
MAX_WASM_PAGE_COUNT->MAX_WASM_PAGE_AMOUNTstdfeature towasmparserdeps.CodeError: now it contains new internal errors from other crates in order to log full information about code errors in one place: seetry_new_codeinpallets/gear/src/lib.rs.InitializationErrorand addDataSectionError