Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): set taken payload back in case of errors in MessageContext #3785

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix(core): set taken payload back in case of errors in MessageContext #3785

merged 1 commit into from
Mar 7, 2024

Conversation

grishasobol
Copy link
Member

@grishasobol grishasobol commented Mar 5, 2024 •
edited
Loading

resolves #3779

@grishasobol grishasobol added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Mar 5, 2024
@grishasobol grishasobol self-assigned this Mar 5, 2024
@grishasobol grishasobol mentioned this pull request Mar 5, 2024
Open
@grishasobol grishasobol marked this pull request as ready for review March 5, 2024 21:27
@grishasobol grishasobol changed the title Draft: fix taken payload fix(core): rtaken payload Mar 5, 2024
@grishasobol grishasobol changed the title fix(core): rtaken payload fix(core): set taken payload back in case of errors Mar 5, 2024
@grishasobol grishasobol added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Mar 5, 2024
@grishasobol grishasobol changed the title fix(core): set taken payload back in case of errors fix(core): set taken payload back in case of errors in MessageContext Mar 6, 2024
@breathx
Copy link
Member

breathx commented Mar 6, 2024

@gshep please take a look as well

gshep
gshep approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grishasobol grishasobol merged commit 529cdef into master Mar 7, 2024
18 checks passed
@grishasobol grishasobol deleted the gsobol-fix-taken-payload branch March 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@breathx breathx breathx approved these changes

Assignees

@grishasobol grishasobol

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set payload back if error occurs in send_commit and reply_commit
3 participants
@grishasobol @breathx @gshep