-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(workspace): move types to gprimitives
crate
#3919
Conversation
7be8a56
to
080f0b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to sync on impl details since this isn't resolve initial issue (motivation of implementing separate crate)
UPD: see #2944
gprimitives
crate
Resolve comments above and good to go from my side 👍🏻 ptal once again @ark0f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👌
Good to merge from my side @StackOverflowExcept1on |
Resolves #2944
Motivation: Mainly this PR is useful for
I/O crates
. If user wants to declare I/O types that depend ongstd
,gprimitives = { workspace = true, features = ["codec"] }
should be used instead.We also encountered linking issue on Windows at hackathon. This is because MSVC linker requires declaration of all imported functions from
gsys
.