Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Context-dependent memory #3922

Merged
merged 10 commits into from
May 6, 2024
Merged

refactor(core): Context-dependent memory #3922

merged 10 commits into from
May 6, 2024

Conversation

ark0f
Copy link
Member

@ark0f ark0f commented Apr 25, 2024

Make it closer to actual executor API which is more flexible

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core labels Apr 25, 2024
breathx
breathx approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho, one dummy ref-wrap was more comfortable than annoying "undefined" context everywhere

@ark0f ark0f merged commit 9ad5f34 into master May 6, 2024
10 checks passed
@ark0f ark0f deleted the al/core-memory branch May 6, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@grishasobol grishasobol Awaiting requested review from grishasobol

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team D1-core Gear Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ark0f @breathx