Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gear-wasm-builder): Support 1.79.0 nightly #3923

Merged
merged 3 commits into from Apr 25, 2024
Merged

fix(gear-wasm-builder): Support 1.79.0 nightly #3923

merged 3 commits into from Apr 25, 2024

Conversation

ukint-vs
Copy link
Member

@ukint-vs ukint-vs commented Apr 25, 2024 •
edited

cargo-metadata output for target names changes with Rust 1.79 due to PR rust-lang/cargo#12783 fixing issue rust-lang/cargo#12780. (TLDR: dashes in target names are replaced with underscores starting with Rust 1.79)

Currently, if a user tries to build a program where the package name contains a dash, they will receive an error message:

error: failed to run custom build command for `gear-guessing-game v0.1.0 (/projects/gear-guessing-game)`

Caused by:
  process didn't exit successfully: `/projects/gear-guessing-game/target/release/build/gear-guessing-game-f6620258e346ef1d/build-script-build` (exit status: 1)
  --- stderr
  error: please add "rlib" to [lib.crate-type]

@gear-tech/dev

@ukint-vs ukint-vs added A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working D5-tooling Helper tools and utilities labels Apr 25, 2024
@ukint-vs ukint-vs requested a review from clearloop April 25, 2024 18:04
@ukint-vs ukint-vs self-assigned this Apr 25, 2024
@ukint-vs ukint-vs force-pushed the vs/fix-wasm-builder-nightly branch from c0c4d57 to 85aa467 Compare April 25, 2024 18:14
grishasobol
grishasobol approved these changes Apr 25, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
utils/wasm-builder/src/crate_info.rs Outdated Show resolved Hide resolved
utils/wasm-builder/src/crate_info.rs Outdated Show resolved Hide resolved
clearloop
clearloop approved these changes Apr 25, 2024
View reviewed changes
utils/wasm-builder/src/crate_info.rs Outdated Show resolved Hide resolved
utils/wasm-builder/src/crate_info.rs Outdated Show resolved Hide resolved
@ukint-vs ukint-vs merged commit 1473560 into master Apr 25, 2024
10 checks passed
@ukint-vs ukint-vs deleted the vs/fix-wasm-builder-nightly branch April 25, 2024 19:15
breathx pushed a commit that referenced this pull request May 7, 2024
@ukint-vs @breathx
fix(gear-wasm-builder): Support 1.79.0 nightly (#3923)
b234924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishasobol grishasobol grishasobol approved these changes

@clearloop clearloop clearloop approved these changes

Assignees

@ukint-vs ukint-vs

Labels
A0-pleasereview PR is ready to be reviewed by the team C0-bug Something isn't working D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ukint-vs @grishasobol @clearloop