Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmarks): update reinstrument bench #4000

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

ByteNacked
Copy link
Member

@ByteNacked ByteNacked commented Jun 5, 2024

Resolves #3992 .

Update reinstrument_per_kb bench (and corresponding weight).
Now, when generating the input module code for this benchmark, table and element sections are used (previously, only the code section was used) because they are heaviest weight-wise.

@reviewer-or-team

@ByteNacked ByteNacked added the A0-pleasereview PR is ready to be reviewed by the team label Jun 5, 2024
@ByteNacked ByteNacked self-assigned this Jun 5, 2024
@ByteNacked ByteNacked force-pushed the rmasl-update-reinstrument-bench branch from 7b7cfb6 to 78e5e62 Compare June 5, 2024 10:05
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikVolf NikVolf merged commit a7fec31 into master Jun 5, 2024
10 checks passed
@NikVolf NikVolf deleted the rmasl-update-reinstrument-bench branch June 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take in account different WASM module sections in re-instrumentation bench
3 participants