Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause program API #691

Merged
merged 67 commits into from Mar 16, 2022
Merged

Pause program API #691

merged 67 commits into from Mar 16, 2022

Conversation

gshep
Copy link
Member

@gshep gshep commented Feb 21, 2022

Resolves #652, resolves #707

  • pallet_gear_program::pause_program
  • pallet_gear_program::resume_program_impl
  • test cases in common crate
  • extrinsic resume_program in pallet_gear_program
  • pallet tests
  • benchmarks

Release notes: Implemented internal API that allows to pause/resume programs execution. Fixed several tiny bugs and refactored the code a bit. Added new extrinsic resume_program. It provides an ability to resume a program by any user/program with enough funds.

This is the next step to implement rent charging for program resources.

@gshep gshep added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D1-core Gear Core D2-node Gear Node labels Feb 21, 2022
@gshep gshep self-assigned this Feb 21, 2022
@NikVolf NikVolf changed the title Gshep/issue 652 Pause program API Feb 21, 2022
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes in order to remove waitlist for paused programs. These messages should be removed and replied by system with error exit code.

pallets/gear-program/README.md Outdated Show resolved Hide resolved
pallets/gear-program/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear-program/src/lib.rs Show resolved Hide resolved
pallets/gear-program/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear-program/src/pause.rs Show resolved Hide resolved
pallets/gear-program/src/pause.rs Outdated Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Mar 14, 2022

Despite this request, looks like good part of removing gear-common in program-management sphere

@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Mar 15, 2022
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gshep gshep merged commit 557c33c into master Mar 16, 2022
@gshep gshep deleted the gshep/issue-652 branch March 16, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes D1-core Gear Core D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_program_terminated_status doesn't remove memory pages Extrinsics resume_program and program destruction
4 participants