Added CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to gcc-9 and higher builds in GitHub Actions CI #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esabol
force-pushed
the
add-GLIBCXX_ASSERTIONS-to-CI-for-gcc-9-and-higher
branch
from
77594ab
to
4af38f8
Compare
esabol
force-pushed
the
add-GLIBCXX_ASSERTIONS-to-CI-for-gcc-9-and-higher
branch
from
4af38f8
to
5a00245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially addresses issue #354 by restoring
CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS"to the gcc-9 and higher builds in GitHub Actions CI. This was previously in the Travis CI, but I forgot to include it in the transition to GitHub Action CI. The gcc documentation says that it "enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers." This was useful in finding multiple errors in the gearmand source code in the past.