skip removing entries from sqlite if store-queue-on-shutdown is used #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esabol
requested changes
Jun 14, 2023
sni
force-pushed
the
improve-store-queue-on-shutdown
branch
from
e898a86
to
ced0d3a
Compare
esabol
requested changes
Jun 15, 2023
sni
force-pushed
the
improve-store-queue-on-shutdown
branch
from
ced0d3a
to
d3304a8
Compare
esabol
requested changes
Jun 16, 2023
if `--store-queue-on-shutdown` is used, database should only be accessed during shutdown and on initial startup. Skipping the done() saves the unnecessary query preparation, database locks, etc... instead truncate queue database after successfully importing the retention database. - fixes gearman#369
sni
force-pushed
the
improve-store-queue-on-shutdown
branch
from
d3304a8
to
120fb35
Compare
esabol
approved these changes
Jun 18, 2023
|
CI tests pass, so I think we're good to merge here. The changes look good to me, but I haven't personally tested them. @sni , have you tested these changes on your system? And they work as desired? |
|
yes, works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
--store-queue-on-shutdownis used, database should only be accessed during shutdown and on initial startup. Skipping the done() saves the unnecessary query preparation, database locks, etc...