Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gearmand text command shutdown #40

Merged
merged 7 commits into from
Dec 14, 2016
Merged

Conversation

p-alik
Copy link
Collaborator

@p-alik p-alik commented Nov 21, 2016

This PL is done with regard to the issue 37.

Copy link
Member

@SpamapS SpamapS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long. Wanted to think about it longer. This is great. I'll squash and merge.

@@ -572,15 +572,6 @@ maxqueue
three optional maximum queue sizes (to enforce for high-, normal-, and
low-priority job submissions).

shutdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should mark it as removed rather than just yanking it.

@SpamapS SpamapS merged commit e586567 into gearman:master Dec 14, 2016
@p-alik p-alik deleted the shutdown branch January 24, 2017 15:54
esabol pushed a commit to esabol/gearmand that referenced this pull request Mar 23, 2017
* remove gearmand support of text command shutdown

* remove gearadmin support of option --shutdown

* cli shutdown test should failed

* remove shutdown from supported administrative protocol commands

* remove --shutdown option  from gearadmin documentation

* remove text command shutdown from supported commands list

* replace the comment on gearadmin shutdown test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants