update outdated code

.travis.yml

@@ -0,0 +1,36 @@
+language: perl
+perl:
+  - "5.24"
+  - "5.22"
+  - "5.20"
+  - "5.18"
+  - "5.16"
+  - "5.14"
+  - "5.12"
+  - "5.10"
+
+sudo: false
+
+before_install:
+  - git clone git://github.com/travis-perl/helpers ~/travis-perl-helpers
+  - source ~/travis-perl-helpers/init
+  - build-perl
+  - perl -V
+  - build-dist
+  - cd $BUILD_DIR
+
+install:
+  - cpanm --quiet --notest Devel::Cover::Report::Coveralls
+  - cpanm --quiet --notest --installdeps .
+
+script:
+  - perl Makefile.PL
+  - make
+  - PERL5OPT=-MDevel::Cover=-coverage,statement,branch,condition,path,subroutine prove -b -r -s t
+
+after_success:
+  - cover -test -report coveralls
+
+branches:
+  only:
+    - master

CHANGES

@@ -1,8 +1,24 @@
+1.14_001 2017-03-14
+        * no more support for text command shutdown
+        * more tests
+
+1.13.002 2016-07-11
+        * pod links to gearmand repaired
+
+1.13.001 2016-07-11
+        * Feature Request: #115368 for Gearman-Server: Allow bind to specific IP address
+        * Fix bug #115458 Distributions contain no tests.
+          Actually only use ok and version tests
+        * Fix bug #89033 typo fixes
+        * Fix bug #107045 [PATCH] fix pod whatis
+        * Fix bug #115350 Uses old port by default (7003) should use 4730
+        * pod usage
+
 1.12 2014-12-14
 
         * Add HACKING file
 
-        * Fix memory leak when clients disconnect (sleeper list isn't pruned).
+        * Fix bug #70728 memory leak when clients disconnect (sleeper list isn't pruned).
           Fixes CPAN RT 70728 (Marsh Yamazaki)
 
 1.11 2010-01-17

MANIFEST

@@ -1,9 +1,17 @@
 CHANGES
-gearmand
+MANIFEST                                 This list of files
+MANIFEST.SKIP
+Makefile.PL
+README.md
+bin/gearmand
 lib/Gearman/Server.pm
 lib/Gearman/Server/Client.pm
 lib/Gearman/Server/Job.pm
 lib/Gearman/Server/Listener.pm
+t/00-use.t
+t/01-gearman-server.t
+t/02-gearman-server-client.t
+t/03-maxqueue.t
 Makefile.PL
 MANIFEST			This list of files
 MANIFEST.SKIP

Makefile.PL

@@ -1,14 +1,44 @@
 use ExtUtils::MakeMaker;
+
 # See lib/ExtUtils/MakeMaker.pm for details of how to influence
 # the contents of the Makefile that is written.
 WriteMakefile(
-              NAME         => 'Gearman::Server',
-              VERSION_FROM => 'lib/Gearman/Server.pm',
-              ABSTRACT_FROM => 'lib/Gearman/Server.pm',
-              EXE_FILES    => ['gearmand'],
-              PREREQ_PM    => {
-                  'Gearman::Util' => 0,
-                  'Danga::Socket' => 1.52,
-              },
-              AUTHOR       => 'Brad Fitzpatrick (brad@danga.com), Brad Whitaker (whitaker@danga.com)',
-              );
+    NAME           => 'Gearman::Server',
+    VERSION_FROM   => 'lib/Gearman/Server.pm',
+    ABSTRACT_FROM  => 'lib/Gearman/Server.pm',
+    EXE_FILES      => ['bin/gearmand'],
+    BUILD_REQUIRES => {
+        "File::Spec"       => 0,
+        "FindBin"          => 0,
+        "IO::Socket::INET" => 0,
+        "Net::EmptyPort"   => 0,
+        "Proc::Guard"      => 0,
+        "Socket"           => 0,
+        "Sys::Hostname"    => 0,
+        "Test::Exception"  => 0,
+        "Test::More"       => 0,
+        "Test::Script"     => 1.12,
+        "Test::TCP"        => 0,
+        "version"          => 0,
+    },
+    PREREQ_PM => {
+        "Danga::Socket"    => 1.52,
+        "Gearman::Util"    => 0,
+        "IO::Socket::INET" => 0,
+        "Sys::Hostname"    => 0,
+        "version"          => 0,
+    },
+    AUTHOR =>
+        'Brad Fitzpatrick (brad@danga.com), Brad Whitaker (whitaker@danga.com)',
+    META_MERGE => {
+        'meta-spec' => { version => 2 },
+        resources   => {
+            repository => {
+                type => 'git',
+                url  => 'https://github.com/p-alik/Gearman-Server.git',
+                web  => 'https://github.com/p-alik/Gearman-Server',
+            },
+        },
+    },
+
+);

README.md

@@ -0,0 +1,14 @@
+Gearman::Server
+===================
+
+[![CPAN version](https://badge.fury.io/pl/Gearman-Server.png)](https://badge.fury.io/pl/Gearman-Server)
+[![Build Status](https://travis-ci.org/p-alik/Gearman-Server.png)](https://travis-ci.org/p-alik/Gearman-Server)
+[![Coverage Status](https://coveralls.io/repos/github/p-alik/Gearman-Server/badge.png)](https://coveralls.io/github/p-alik/Gearman-Server)
+
+This repository contains perl implementation of [Gearman](http://gearman.org) daemon
+
+see also
+------------
+* [Gearman::Client](https://metacpan.org/pod/Gearman::Client) - Client for gearman distributed job system
+* [Gearman::Worker](https://metacpan.org/pod/Gearman::Worker) - Worker for gearman distributed job system
+

gearmand → bin/gearmand

@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
 
 =head1 NAME
 
@@ -23,15 +23,21 @@ daemonization.
 Make the daemon run in the background (good for init.d scripts, bad
 for running under daemontools/supervise).
 
-=item --port=7003 / -p 7003
+=item --port=4730 / -p 4730
 
-Set the port number, defaults to 7003.
+Set the port number, default to 4730.
+
+=item --listen hostname / -L hostname
+
+Address the server should listen on.
+
+Default is
 
 =item --pidfile=/some/dir/gearmand.pid
 
 Write a pidfile when starting up
 
-=item --debug=1
+=item --debug
 
 Enable debugging (currently the only debug output is when a client or worker connects).
 
@@ -59,9 +65,13 @@ the queue.
 Zero (0) means go as fast as possible, but not all at the same time. Similar to -1 on --wakeup, but
 is more cooperative in gearmand's multitasking model.
 
-Negative One (-1) means that this event won't happe, so only the initial workers will be woken up to
+Negative One (-1) means that this event won't happen, so only the initial workers will be woken up to
 handle jobs in the queue.
 
+=item --version
+
+Display the version and exit.
+
 =back
 
 =head1 COPYRIGHT
@@ -95,116 +105,98 @@ L<Gearman::Client::Async>
 package Gearmand;
 use strict;
 use warnings;
+
 BEGIN {
-    $^P = 0x200;  # Provide informative names to anonymous subroutines
+    # Provide informative names to anonymous subroutines
+    $^P = 0x200;
 }
-use FindBin;
-use lib "$FindBin::Bin/lib";
+
 use Gearman::Server;
 
-use Getopt::Long;
 use Carp;
 use Danga::Socket 1.52;
-use IO::Socket::INET;
+use Getopt::Long;
 use POSIX ();
-use Gearman::Util;
-use vars qw($DEBUG);
+use Pod::Usage;
 use Scalar::Util ();
 
-$DEBUG = 0;
+use vars qw($DEBUG);
 
-my (
-    $daemonize,
-    $nokeepalive,
-    $notify_pid,
-    $opt_pidfile,
-    $accept,
-    $wakeup,
-    $wakeup_delay,
-   );
-my $conf_port = 7003;
-
-Getopt::Long::GetOptions(
-                         'd|daemonize'    => \$daemonize,
-                         'p|port=i'       => \$conf_port,
-                         'debug=i'        => \$DEBUG,
-                         'pidfile=s'      => \$opt_pidfile,
-                         'accept=i'       => \$accept,
-                         'wakeup=i'       => \$wakeup,
-                         'wakeup-delay=f' => \$wakeup_delay,
-                         'notifypid|n=i'  => \$notify_pid,  # for test suite only.
-                         );
+$DEBUG = 0;
+my $port = 4730;
+
+GetOptions(
+    'accept=i'       => \my $accept,
+    'debug'          => \$DEBUG,
+    'd|daemonize'    => \my $daemonize,
+    'listen|L=s'     => \my $listen,
+    'pidfile=s'      => \my $opt_pidfile,
+    'p|port=i'       => \$port,
+    'wakeup-delay=f' => \my $wakeup_delay,
+    'wakeup=i'       => \my $wakeup,
+    'version|V'      => sub {
+        print "Gearman::Server $Gearman::Server::VERSION$/";
+        exit;
+    },
+    'help|?' => sub {
+        pod2usage(-verbose => 1);
+        exit;
+    },
+
+    # for test suite only.
+    'notifypid|n=i' => \my $notify_pid,
+);
 
 daemonize() if $daemonize;
 
-# true if we've closed listening socket, and we're waiting for a
-# convenient place to kill the process
-our $graceful_shutdown = 0;
-
-$SIG{'PIPE'} = "IGNORE";  # handled manually
-
+# handled manually
+$SIG{'PIPE'} = "IGNORE";
 my $server = Gearman::Server->new(
-                                  wakeup          => $wakeup,
-                                  wakeup_delay    => $wakeup_delay,
-             );
-my $ssock  = $server->create_listening_sock($conf_port, accept_per_loop => $accept);
+    wakeup       => $wakeup,
+    wakeup_delay => $wakeup_delay,
+);
+my $ssock = $server->create_listening_sock(
+    $port,
+    accept_per_loop => $accept,
+    local_addr      => $listen
+);
 
 if ($opt_pidfile) {
     open my $fh, '>', $opt_pidfile or die "Could not open $opt_pidfile: $!";
     print $fh "$$\n";
     close $fh;
 }
 
-sub shutdown_graceful {
-    return if $graceful_shutdown;
-
-    my $ofds = Danga::Socket->OtherFds;
-    delete $ofds->{fileno($ssock)};
-    $ssock->close;
-    $graceful_shutdown = 1;
-    shutdown_if_calm();
-}
-
-sub shutdown_if_calm {
-    exit 0 unless $server->jobs_outstanding;
-}
-
 sub daemonize {
-    my ($pid, $sess_id, $i);
-
+    my ($pid, $sess_id);
     ## Fork and exit parent
     if ($pid = fork) { exit 0; }
 
     ## Detach ourselves from the terminal
     croak "Cannot detach from controlling terminal"
         unless $sess_id = POSIX::setsid();
 
-    ## Prevent possibility of acquiring a controling terminal
+    ## Prevent possibility of acquiring a controlling terminal
     $SIG{'HUP'} = 'IGNORE';
     if ($pid = fork) { exit 0; }
 
     ## Change working directory
-    chdir "/";
+    chdir("/") || croak "can't chdir to /: $!";
 
     ## Clear file creation mask
     umask 0;
 
     ## Close open file descriptors
-    close(STDIN);
-    close(STDOUT);
-    close(STDERR);
+    close(STDIN)  || croak "can't close STDIN: $!";
+    close(STDOUT) || croak "can't close STDOUT: $!";
+    close(STDERR) || croak "can't close STDERR: $!";
 
     ## Reopen stderr, stdout, stdin to /dev/null
-    open(STDIN,  "+>/dev/null");
-    open(STDOUT, "+>&STDIN");
-    open(STDERR, "+>&STDIN");
-}
+    open(STDIN,  "+>/dev/null") || croak "can't write to /dev/null: $!";
+    open(STDOUT, "+>&STDIN")    || croak "can't dup STDOUT to STDIN: $!";
+    open(STDERR, "+>&STDIN")    || croak "can't dup STDERR to STDIN: $!";
+} ## end sub daemonize
 
 kill 'USR1', $notify_pid if $notify_pid;
 Danga::Socket->EventLoop();
 
-# Local Variables:
-# mode: perl
-# c-basic-indent: 4
-# indent-tabs-mode: nil
-# End: