Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve misleading property kirby-reporter.disabled #24

Closed
gearsdigital opened this issue Jan 17, 2020 · 0 comments · Fixed by #27
Closed

improve misleading property kirby-reporter.disabled #24

gearsdigital opened this issue Jan 17, 2020 · 0 comments · Fixed by #27
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
2.0.0

Comments

@gearsdigital
Copy link
Owner

Right now it's a bit confusing to set kirby-reporter.disabled to false in order to enable the plugin. I also dislike that we force the user to explicitly set the aforementioned property to do anything at all.

So rename kirby-reporter.disabled to kirby-reporter.enabled and make it true by default.
@gearsdigital gearsdigital added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 17, 2020
@gearsdigital gearsdigital added this to the 2.0.0 milestone Jan 17, 2020
gearsdigital pushed a commit that referenced this issue Jan 17, 2020
feat: reduce configuration complexity
aef19c1 
BREAKING CHANGE: property kirby-reporter.disabled is renamed to kirby-reporter.enabled. Please update your configuration accordingly.

Closes #24
@gearsdigital gearsdigital mentioned this issue Jan 17, 2020
Merged
gearsdigital pushed a commit that referenced this issue Jan 18, 2020
feat: reduce configuration complexity
9276c67 
BREAKING CHANGE: property kirby-reporter.disabled is renamed to kirby-reporter.enabled. Please update your configuration accordingly.

Closes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat: reduce configuration complexity gearsdigital/reporter-for-kirby
1 participant
@gearsdigital