Fix for #450 unexpected pages are now checked after the atCheck fails #127
Conversation
leonard84
force-pushed
the
fix-unexpected-changes
branch
from
b2d4e21
to
fea3f34
Compare
leonard84
force-pushed
the
fix-unexpected-changes
branch
from
fea3f34
to
acb5d6c
Compare
There was a problem hiding this comment.
Other than the couple of small changes requested it LGTM. This will be a nice perf improvement if unexpected pages are used.
Don't forget to add yourself to contributors at https://github.com/geb/geb/blob/master/doc/manual/src/docs/asciidoc/140-project.adoc#contributors and add your fix to changelog at https://github.com/geb/geb/blob/master/doc/manual/src/docs/asciidoc/140-project.adoc#imporevements
| errorThrown | ||
| } | ||
|
|
||
| boolean getAtResult() { |
There was a problem hiding this comment.
This method is unused and thus unnecessary.
| def verificationResult = getAtVerificationResult(true) | ||
| if (!verificationResult) { | ||
| getInitializedBrowser().checkIfAtAnUnexpectedPage(getClass()) | ||
| if (verificationResult.errorThrown) { |
There was a problem hiding this comment.
Instead of exposing errorThrown property please add AtVerificationResult.rethrowAnyErrors() which will possibly throw the error if one has occurred and use it here.
| at ExpectedPage | ||
| } | ||
|
|
||
| void 'unexpected pages are checked only if the atCheck for the expected page fails'() { |
There was a problem hiding this comment.
I think that this test is redundant because it tests the exact same path as the one which follows, i.e. an exception is thrown when we end up at an unexpected page. Or am I'm missing something?
|
I applied the changes previously requested myself. Thanks for the contribution @leonard84! |
No description provided.