Get Supersets does not use color id, just gets all supersets

[Yoonwoo]

The subsets function implements it with ?color_id parameter but supersets has color id just after / which is disregarded.

Can change to be like subsets function and fix:

public async Task<Superset[]> GetSupersetsAsync(ItemType type, string no, int colorId = 0)
        {
            var typeString = type.GetStringValueOrDefault();
            var builder = new UriBuilder(new Uri(_baseUri, $"items/{typeString}/{no}/supersets"));
            var query = HttpUtility.ParseQueryString(builder.Query);
            query["color_id"] = colorId.ToString();
            builder.Query = query.ToString();
            var url = builder.ToString();

            var method = HttpMethod.Get;
            var responseBody = await ExecuteRequest(url, method);

            var data = ParseResponse<Superset[]>(responseBody, 200, url, method);
            return data;
        }

In GetSupersetsDemo, example

var supersets = await client.GetSupersetsAsync(ItemType.Part, "40232", 8);

gets all supersets, not just color 8, works after changing

[gebirgslok]

Hi,

thanks for this catch. It's fixed and there will be a new NuGet package version soon.

Thanks very much

[Yoonwoo]

Cool, great client btw. Its a much higher standard than I could ever make.

[Yoonwoo]

Also not sure what you have in mind, but obviously its easy to make the function allow no color id and get all, it defaults to 0 for subsets and supersets which makes less sense for parts than it does for minifigures or sets.

if (colorId != -1)
            {
                var query = HttpUtility.ParseQueryString(builder.Query);
                query["color_id"] = colorId.ToString();
                builder.Query = query.ToString();
            }

[gebirgslok]

Cool, great client btw. Its a much higher standard than I could ever make.

Thanks. Just try to improve every day and never stop learning. This lib has a lot of things to improve as well (like injecting HttpClient, ServiceCollection extension etc.)

I'll look into that colorId = 0 issue again. The client should not be more complex than it has to (the server handles colorId = 0 anyway).