Fixed #3

gebirgslok · Sep 19, 2021 · 661716c · 661716c
1 parent ba44fcf
commit 661716c
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 10 deletions.
diff --git a/BricklinkSharp.Client/BricklinkClient.cs b/BricklinkSharp.Client/BricklinkClient.cs
@@ -283,10 +283,15 @@ public Uri EnsureImageUrlScheme(string imageUrl, string scheme = "https")
             return new Uri($"{scheme}:{imageUrl}");
         }
 
-        public async Task<Superset[]> GetSupersetsAsync(ItemType type, string no, int colorId)
+        public async Task<Superset[]> GetSupersetsAsync(ItemType type, string no, int colorId = 0)
         {
             var typeString = type.GetStringValueOrDefault();
-            var url = new Uri(_baseUri, $"items/{typeString}/{no}/supersets/{colorId}").ToString();
+
+            var url = new Uri(_baseUri, 
+                colorId > 0 ? 
+                    $"items/{typeString}/{no}/supersets?color_id={colorId}" :
+                    $"items/{typeString}/{no}/supersets")
+                .ToString();
 
             var method = HttpMethod.Get;
             var responseBody = await ExecuteRequest(url, method);

diff --git a/BricklinkSharp.Client/BricklinkSharp.Client.csproj b/BricklinkSharp.Client/BricklinkSharp.Client.csproj
@@ -3,10 +3,10 @@
     <TargetFrameworks>netstandard2.0;netcoreapp3.0;netcoreapp3.1;net5.0</TargetFrameworks>
     <LangVersion>8.0</LangVersion>
     <!-- version numbers will be updated by build -->
-    <Version>1.1.0.0</Version>
-    <FileVersion>1.1.0.0</FileVersion>
-    <InformationalVersion>1.1.0.0</InformationalVersion>
-    <PackageVersion>1.1.0</PackageVersion>
+    <Version>1.1.1.0</Version>
+    <FileVersion>1.1.1.0</FileVersion>
+    <InformationalVersion>1.1.1.0</InformationalVersion>
+    <PackageVersion>1.1.1</PackageVersion>
     <Authors>Jens Eisenbach</Authors>
     <Product>BricklinkSharp</Product>
     <Description>Strongly-typed, easy-to-use API client for the bricklink marketplace.</Description>
@@ -23,6 +23,7 @@
     <RepositoryType>Git</RepositoryType>
     <Nullable>enable</Nullable>
     <GeneratePackageOnBuild>false</GeneratePackageOnBuild>
+    <CheckEolTargetFramework>false</CheckEolTargetFramework>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)'=='netstandard2.0'">
     <AssemblyTitle>BricklinkSharp .Net Standard 2.0</AssemblyTitle>

diff --git a/BricklinkSharp.Client/IBricklinkClient.cs b/BricklinkSharp.Client/IBricklinkClient.cs
@@ -53,7 +53,7 @@ public interface IBricklinkClient : IDisposable
 
         Uri EnsureImageUrlScheme(string imageUrl, string scheme = "https");
 
-        Task<Superset[]> GetSupersetsAsync(ItemType type, string no, int colorId);
+        Task<Superset[]> GetSupersetsAsync(ItemType type, string no, int colorId = 0);
 
         Task<Subset[]> GetSubsetsAsync(ItemType type, string no, int colorId = 0, bool? includeOriginalBox = null,
             bool? includeInstruction = null, bool? breakMinifigs = null, bool? breakSubsets = null);

diff --git a/BricklinkSharp.Demos/CatalogDemos.cs b/BricklinkSharp.Demos/CatalogDemos.cs
@@ -65,6 +65,15 @@ public static async Task GetSupersetsDemo()
             PrintHelper.PrintAsJson(supersets);
         }
 
+        public static async Task GetSupersetsDemo2()
+        {
+            using var client = BricklinkClientFactory.Build();
+            var colorId = 8; //Brown
+            var supersets = await client.GetSupersetsAsync(ItemType.Part, "40232", colorId);
+
+            PrintHelper.PrintAsJson(supersets);
+        }
+
         public static async Task GetItemDemo()
         {
             using var client = BricklinkClientFactory.Build();
@@ -153,7 +162,7 @@ public static void GetInstructionImageDemo()
             }
         }
 
-        public static void GetOrignalBoxImageDemo()
+        public static void GetOriginalBoxImageDemo()
         {
             using var client = BricklinkClientFactory.Build();
 

diff --git a/BricklinkSharp.Demos/Program.cs b/BricklinkSharp.Demos/Program.cs
@@ -43,12 +43,13 @@ static async Task Main()
             CatalogDemos.GetPartImageForColorDemo();
             CatalogDemos.GetBookImageDemo();
             CatalogDemos.GetGearImageDemo();
-            CatalogDemos.GetCatalogImageDemo(); 
+            CatalogDemos.GetCatalogImageDemo();
             CatalogDemos.GetInstructionImageDemo();
-            CatalogDemos.GetOrignalBoxImageDemo();
+            CatalogDemos.GetOriginalBoxImageDemo();
             CatalogDemos.EnsureImageUrlSchemeDemo();
             await CatalogDemos.GetItemDemo();
             await CatalogDemos.GetSupersetsDemo();
+            await CatalogDemos.GetSupersetsDemo2();
             await CatalogDemos.GetSubsetsDemo();
             await CatalogDemos.GetPriceGuideDemo();
             await CatalogDemos.GetKnownColorsDemo();