Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reasonable values for quantum yield #157

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

stineb
Copy link
Collaborator

@stineb stineb commented Jun 9, 2023

Specified a plausible range for sensitivity analysis of kphio and its temperature dependency parameters and revised formulation of the equation.
Visualisation see here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d82adba) 93.53% compared to head (6ba0925) 93.53%.

❗ Current head 6ba0925 differs from pull request most recent head 55095e4. Consider uploading reports for the commit 55095e4 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          12       12           
  Lines        1083     1083           
=======================================
  Hits         1013     1013           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pepaaran pepaaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pepaaran pepaaran merged commit 4323fc6 into master Jun 9, 2023
7 checks passed
@pepaaran pepaaran deleted the quantum_yield_values branch June 9, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants