Fix/make format target #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -63,8 +63,7 @@ ready for review:: | |||
| - [ ] If it introduces new functionality in scripts/ is it tested? | |||
| Check for code coverage. | |||
| - [ ] Is it well formatted? Look at `make pep8`, `make diff_pylint_report`, | |||
| `make cppcheck`, and `make doc` output. Use `make autopep8`, | |||
| `astyle -A10 --max-code-length=80`, and manual fixing as needed. | |||
| `make cppcheck`, and `make doc` output. Use `make format` as needed, | |||
There was a problem hiding this comment.
Lets leave the comment about manual fixing in. Autopep8 can't fix all PEP8 errors automatically
|
retest this please |
|
2 nits; otherwise this looks good to me. |
|
retest this please |
1 similar comment
|
retest this please |
|
Please update the pep8 version to 1.5.7 so that |
|
Test PASSed. |
|
@brtaylor92 can you either undo the formating or merge with master? |
|
Also your commits aren't being linked to your github account. I'm guessing the email address needs to be changed. |
brtaylor92
force-pushed
the
fix/make_format_target
branch
from
36201fc
to
8c2e9e1
Compare
|
Test FAILed. |
|
Test PASSed. |
|
retest this please |
|
Test PASSed. |
… make format target Run autopep8 Update pep8 to 1.5.7
brtaylor92
force-pushed
the
fix/make_format_target
branch
from
80a02e7
to
b131029
Compare
|
Test PASSed. |
|
Thanks for the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'astyle' and 'format' targets to Makefile