Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt-release should quit if any of the additional tasks (i.e.: beforeBump) fail #138

Open
Kjir opened this issue Oct 16, 2015 · 4 comments

Comments

@Kjir
Copy link

Kjir commented Oct 16, 2015

Currently if I specify in my config options a beforeBump task like test, which of course runs my unit tests, grunt-release will still continue its execution even if my tests are failing. I would expect it to stop if a task fails.

For the beforeBump configuration the workaround is to define a grunt task like this:

grunt.registerTask('my-release-task', ['test', 'release']);

but for the other hooks there is no workaround.

knksmith57 pushed a commit to knksmith57/grunt-release that referenced this issue Dec 18, 2015
knksmith57 pushed a commit to knksmith57/grunt-release that referenced this issue Dec 18, 2015
@knksmith57
Copy link

@Kjir just worked a fix for this via #143.

Hopefully we can get this merged soon as it's a very small patch.

@astronati
Copy link

This bug is still reproducible. Is there any update?

@matmar10
Copy link

matmar10 commented Oct 1, 2016

👍

@bago
Copy link

bago commented Mar 1, 2018

Here are 2+ years old fixed issues never released: do you need help with project maintenance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants